* 2.4 direct_IO API changing?
@ 2003-07-06 19:11 Jeff Garzik
2003-07-06 20:03 ` Alan Cox
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Garzik @ 2003-07-06 19:11 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: LKML
I see in 2.4.22-BK-latest:
> - int (*direct_IO)(int, struct inode *, struct kiobuf *, unsigned long, int);
> + int (*direct_IO)(int, struct file *, struct kiobuf *, unsigned long, int
Should this really be changing in the middle of a stable series?
I realize that vendor's are already shipping this difference, but
still... it's a bit of an abrupt midseries change that can potentially
break working code.
Jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: 2.4 direct_IO API changing?
2003-07-06 19:11 2.4 direct_IO API changing? Jeff Garzik
@ 2003-07-06 20:03 ` Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2003-07-06 20:03 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Marcelo Tosatti, LKML
On Sul, 2003-07-06 at 20:11, Jeff Garzik wrote:
> I see in 2.4.22-BK-latest:
>
> > - int (*direct_IO)(int, struct inode *, struct kiobuf *, unsigned long, int);
> > + int (*direct_IO)(int, struct file *, struct kiobuf *, unsigned long, int
>
>
> Should this really be changing in the middle of a stable series?
>
> I realize that vendor's are already shipping this difference, but
> still... it's a bit of an abrupt midseries change that can potentially
> break working code.
Its something most people are already shipping and something you
actually do need for some of the direct IO stuff.
BTW: Marcelo your mail system is broken *again*
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-07-06 19:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-07-06 19:11 2.4 direct_IO API changing? Jeff Garzik
2003-07-06 20:03 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox