Re: [PATCH] new quota code

Re: [PATCH] new quota code

[Jeff Garzik]

Linux Kernel Mailing List wrote:
> ChangeSet 1.1059, 2003/07/07 17:01:15-03:00, hch@lst.de
> 
> 	[PATCH] new quota code
> 	
> 	Okay, here's the quota patch.  Basically all changes are from Jan Kara
> 	and I backport them from 2.5.  The 32bit quota code has been shipped
> 	by the commercial vendors ever since they used Linux 2.4 and this
> 	particular codebase with backwards compatiblity support is around
> 	in the 2.5, the XFS tree, -ac and -aa for a long time.  The only
> 	change over that version is that support for the old 16bit quota
> 	format and the old quotactl ABI is enabled unconditionally, i.e.
> 	there's no way to render your system unusable by wrong make config
> 	choices [1].
> 	
> 	[1] This also mean completely dropping support for the interim ABI
> 	used in the early 32bit quota patches as it's mutally incompatible
> 	to the old ABI.  But we never ever shipped that in any mainline kernels
> 	so there's no problem.


"no problem" being defined here as "multiple vendors shipped it but I 
don't care", right?

Why do we need a third (fourth?) 2.4 quota abi/api floating around?

	Jeff

Re: [PATCH] new quota code

[Christoph Hellwig]

On Mon, Jul 07, 2003 at 07:02:42PM -0400, Jeff Garzik wrote:
> > 	[1] This also mean completely dropping support for the interim ABI
> > 	used in the early 32bit quota patches as it's mutally incompatible
> > 	to the old ABI.  But we never ever shipped that in any mainline kernels
> > 	so there's no problem.
> 
> 
> "no problem" being defined here as "multiple vendors shipped it but I 
> don't care", right?

no problem as in this was neve supported in mainline and we don't need
to introduce a third quota ABI to official kernels.  The old ABI is
still supported and the 2.5 one in addition.

> Why do we need a third (fourth?) 2.4 quota abi/api floating around?

We don't.  We support the old one and the 2.5 one.