From: Jeff Garzik <jgarzik@pobox.com>
To: "J.A. Magallon" <jamagallon@able.es>
Cc: Lista Linux-Kernel <linux-kernel@vger.kernel.org>,
Marcelo Tosatti <marcelo@conectiva.com.br>
Subject: Re: [PATCH] 2.4.22-pre3: P3 and P4 for chekc_gcc
Date: Wed, 09 Jul 2003 19:02:00 -0400 [thread overview]
Message-ID: <3F0C9EE8.2050005@pobox.com> (raw)
In-Reply-To: <20030709223355.GA2604@werewolf.able.es>
J.A. Magallon wrote:
> --- linux-2.4.21-bp1/arch/i386/Makefile.orig 2003-06-18 23:40:25.000000000 +0200
> +++ linux-2.4.21-bp1/arch/i386/Makefile 2003-06-18 23:59:25.000000000 +0200
> @@ -53,11 +53,11 @@
> endif
>
> ifdef CONFIG_MPENTIUMIII
> -CFLAGS += -march=i686
> +CFLAGS += $(call check_gcc,-march=pentium3,-march=i686)
> endif
>
> ifdef CONFIG_MPENTIUM4
> -CFLAGS += -march=i686
> +CFLAGS += $(call check_gcc,-march=pentium4,-march=i686)
> endif
Looks ok to me (I run this patch locally, and also am the one who
submitted the check_gcc patch).
I haven't had any problems at all, but I'm curious if anyone has any
negative feedback... It's rather easy to be conservative and ignore the
patch, since -march=i686 should always work.
Jeff
next prev parent reply other threads:[~2003-07-09 22:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-09 22:33 [PATCH] 2.4.22-pre3: P3 and P4 for chekc_gcc J.A. Magallon
2003-07-09 23:02 ` Jeff Garzik [this message]
2003-07-09 23:07 ` J.A. Magallon
2003-07-09 23:57 ` Jeff Garzik
2003-07-09 23:40 ` Kurt Wall
-- strict thread matches above, loose matches on Subject: below --
2003-07-10 7:44 Margit Schubert-While
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F0C9EE8.2050005@pobox.com \
--to=jgarzik@pobox.com \
--cc=jamagallon@able.es \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox