[PATCH] do_generic_direct_write: bad flag check

J.A. Magallon
2003-07-09T22:59:13Z

On 07.10, Marcelo Tosatti wrote:
>
> Hi,
>
> Here goes -pre4. It contains a lot of updates and fixes.
>

--- linux-2.4.22-pre2-jam1/mm/filemap.c.orig 2003-06-28 01:55:36.000000000 +0200
+++ linux-2.4.22-pre2-jam1/mm/filemap.c 2003-06-28 01:55:45.000000000 +0200
@@ -3223,7 +3223,7 @@
if (err != 0 || count == 0)
goto out;

- if (!file->f_flags & O_DIRECT)
+ if (!(file->f_flags & O_DIRECT))
BUG();

remove_suid(inode);

...but sure the fix in -ac is better.

--
J.A. Magallon <jamagallon@able.es> \ Software is like sex:
werewolf.able.es \ It's better when it's free
Mandrake Linux release 9.2 (Cooker) for i586
Linux 2.4.22-pre2-jam1 (gcc 3.3 (Mandrake Linux 9.2 3.3-2mdk))