From: Daniel <daniel@hawton.org>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] do_generic_direct_write: bad flag check
Date: Wed, 09 Jul 2003 20:48:43 -0700 [thread overview]
Message-ID: <3F0CE21B.2050309@hawton.org> (raw)
In-Reply-To: <Pine.LNX.4.55L.0307100028320.6629@freak.distro.conectiva>
Marcelo Tosatti wrote:
>
> On Thu, 10 Jul 2003, J.A. Magallon wrote:
>
>
>>On 07.10, Marcelo Tosatti wrote:
>>
>>>Hi,
>>>
>>>Here goes -pre4. It contains a lot of updates and fixes.
>>>
>>
>>--- linux-2.4.22-pre2-jam1/mm/filemap.c.orig 2003-06-28 01:55:36.000000000 +0200
>>+++ linux-2.4.22-pre2-jam1/mm/filemap.c 2003-06-28 01:55:45.000000000 +0200
>>@@ -3223,7 +3223,7 @@
>> if (err != 0 || count == 0)
>> goto out;
>>
>>- if (!file->f_flags & O_DIRECT)
>>+ if (!(file->f_flags & O_DIRECT))
>> BUG();
>>
>> remove_suid(inode);
>>
>>...but sure the fix in -ac is better.
>
>
> What is the difference between the fix in -ac and yours?
There's a difference?? Looks the same to me. Unless there is part of
the patch we don't see.
next prev parent reply other threads:[~2003-07-10 3:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-09 22:24 Linux 2.4.22-pre4 Marcelo Tosatti
2003-07-09 22:48 ` J.A. Magallon
2003-07-09 22:56 ` Herbert Pötzl
2003-07-09 22:51 ` Alex Romosan
2003-07-10 0:02 ` -pre4 fixed on ftp.kernel.org " Marcelo Tosatti
2003-07-09 23:04 ` Onur Kucuk
2003-07-09 23:13 ` [PATCH] do_generic_direct_write: bad flag check J.A. Magallon
2003-07-10 3:29 ` Marcelo Tosatti
2003-07-10 3:48 ` Daniel [this message]
2003-07-10 0:03 ` Linux 2.4.22-pre4 J.A. Magallon
2003-07-10 0:29 ` [PATCH] hfsplus: group Apple FS's and help text J.A. Magallon
2003-07-10 0:36 ` J.A. Magallon
2003-07-10 5:23 ` Linux 2.4.22-pre4 Aschwin Marsman
2003-07-10 7:58 ` Willy Tarreau
2003-07-10 15:51 ` compile warnings Rafał 'rmrmg' Roszak
2003-07-10 22:26 ` Diego Calleja García
2003-07-11 0:18 ` Rafał 'rmrmg' Roszak
2003-07-29 14:08 ` 2.4.22-pre4: devfs on initrd stays busy after pivot_root Andreas Haumer
2003-07-29 14:16 ` Alan Cox
2003-07-29 14:54 ` Herbert Pötzl
2003-07-30 9:54 ` Andreas Haumer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F0CE21B.2050309@hawton.org \
--to=daniel@hawton.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox