Re: Style question: Should one check for NULL pointers?

Larry McVoy
2003-07-10T22:15:27Z

On Thu, Jul 10, 2003 at 03:13:52PM -0700, H. Peter Anvin wrote:
> Followup to: <3F0DD3FD.3030403@triphoenix.de>
> By author: Dennis Bliefernicht <itsme.nospam@triphoenix.de>
> In newsgroup: linux.dev.kernel
> >
> > The problem is IMHO code where some pretty fragile things are handled,
> > especially file systems. I'd say: DO the paranoia checks if some fragile
> > things are involved like key structures of the file system that can take
> > _permanent_ damage. If you check for a NULL pointer you still have the
> > chance to properly leave the system in a consistent state and no user
> > will be happy if his filesystem goes messy just because someone saved a
> > check to have nicer code, even if the original of the NULL pointer
> > wasn't his fault, even if it's a developing version. So if the check
> > isn't a total performace disaster, do it whenever permanent damage could
> > occur.
> >
>
> Actually, you have it somewhat backwards.
>
> In most cases, checking for NULL pointers (and returning an error
> whatnot) is actually *more* likely to cause permanent damage than
> having the kernel bomb out. At least with the kernel bombing out you
> won't keep grinding on a filesystem for which your kernel
> datastructures are bad. This is *IMPORTANT*.

In BK, we have a READ_ONLY flag on each revision history file. Whenever
we get into a state where we don't understand what's going on, we set that
flag. That flag is checked in the code path which writes the file and it
will simply refuse the write the file if the flag is set.

Seems like the same idea would work here. I can imagine a lot of use for
a file system which remounts itself as read only the second it sees a
problem it can't handle. At least you can poke around and try and figure
out what is going on.
--
---
Larry McVoy lm at bitmover.com http://www.bitmover.com/lm