From: Lou Langholtz <ldl@aros.net>
To: Paul Clements <Paul.Clements@SteelEye.com>,
Andrew Morton <akpm@digeo.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
kernel@steeleye.com
Cc: torvalds@osdl.org
Subject: Re: NBD oops in 2.5-bk.
Date: Fri, 11 Jul 2003 10:58:50 -0600 [thread overview]
Message-ID: <3F0EECCA.6090205@aros.net> (raw)
Rather than pushing the memset zero hack to NBD to work around this
problem, how about we fix this problem where it should be fixed - from
within the blk_init_queue() function. I'm sorry I'm not offerring a real
patch right here myself for this but I'd rather defer that to the blk_*
API experts. The basics of such a patch though would be to simply add
memset(&q->kobj, 0, sizeof(struct kobject)) to the top of the
blk_init_queue() function. Andrew's been super involved and has done
wonderful things with the block layer so I really want him to think
about where and how to best to initialize the new kobj field of
request_queue or to say why he (or someone else as qualified) believes
it should be the driver's responsibility to init this field (instead of
the blk_init_queue function init'ing it). Thanks!
next reply other threads:[~2003-07-11 16:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-11 16:58 Lou Langholtz [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-07-10 17:20 NBD oops in 2.5-bk Dave Jones
2003-07-10 18:53 ` Paul Clements
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F0EECCA.6090205@aros.net \
--to=ldl@aros.net \
--cc=Paul.Clements@SteelEye.com \
--cc=akpm@digeo.com \
--cc=kernel@steeleye.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox