From: Lou Langholtz <ldl@aros.net>
To: linux-kernel <linux-kernel@vger.kernel.org>,
Jens Axboe <axboe@suse.de>, Andrew Morton <akpm@digeo.com>
Subject: [RFC][PATCH 2.6.0-test2] get rid of unused request_queue field queue_wait
Date: Mon, 28 Jul 2003 02:03:04 -0600 [thread overview]
Message-ID: <3F24D8B8.5030107@aros.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 332 bytes --]
Are we going to use the queue_wait field of struct request_queue
someday? As of 2.6.0-test2, I don't see any use of it. If it's not
needed anymore, the following patch gets rid of it. Tested this patch by
compiling for i386 and also doing a grep through all .h and .c files to
see if it's used somewhere else (admittedly weak).
[-- Attachment #2: patch-2.6.0-test2-no_queue_wait --]
[-- Type: text/plain, Size: 893 bytes --]
diff -urN linux-2.6.0-test2/drivers/block/ll_rw_blk.c linux-2.6.0-test2-no_queue_wait/drivers/block/ll_rw_blk.c
--- linux-2.6.0-test2/drivers/block/ll_rw_blk.c 2003-07-27 19:02:48.000000000 -0600
+++ linux-2.6.0-test2-no_queue_wait/drivers/block/ll_rw_blk.c 2003-07-27 22:36:16.000000000 -0600
@@ -225,7 +225,6 @@
*/
blk_queue_bounce_limit(q, BLK_BOUNCE_HIGH);
- init_waitqueue_head(&q->queue_wait);
INIT_LIST_HEAD(&q->plug_list);
}
diff -urN linux-2.6.0-test2/include/linux/blkdev.h linux-2.6.0-test2-no_queue_wait/include/linux/blkdev.h
--- linux-2.6.0-test2/include/linux/blkdev.h 2003-07-27 19:02:52.000000000 -0600
+++ linux-2.6.0-test2-no_queue_wait/include/linux/blkdev.h 2003-07-27 22:18:19.000000000 -0600
@@ -337,8 +337,6 @@
unsigned long seg_boundary_mask;
unsigned int dma_alignment;
- wait_queue_head_t queue_wait;
-
struct blk_queue_tag *queue_tags;
/*
next reply other threads:[~2003-07-28 7:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-28 8:03 Lou Langholtz [this message]
2003-07-28 12:18 ` [RFC][PATCH 2.6.0-test2] get rid of unused request_queue field queue_wait Jens Axboe
2003-07-28 13:20 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F24D8B8.5030107@aros.net \
--to=ldl@aros.net \
--cc=akpm@digeo.com \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox