From: Manfred Spraul <manfred@colorfullife.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Andries.Brouwer@cwi.nl, torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] select fix
Date: Tue, 29 Jul 2003 19:57:04 +0200 [thread overview]
Message-ID: <3F26B570.7020004@colorfullife.com> (raw)
In-Reply-To: <20030729103630.7fb415cb.akpm@osdl.org>
Andrew Morton wrote:
>Andries.Brouwer@cwi.nl wrote:
>
>
>>- if (tty->driver->chars_in_buffer(tty) < WAKEUP_CHARS)
>>+ if (!tty->stopped && tty->driver->chars_in_buffer(tty) < WAKEUP_CHARS)
>> mask |= POLLOUT | POLLWRNORM;
>>
>>
>
>Manfred sent a patch through esterday which addresses it this way:
>
>- if (tty->driver->chars_in_buffer(tty) < WAKEUP_CHARS)
>+ if (tty->driver->chars_in_buffer(tty) < WAKEUP_CHARS &&
>+ tty->driver->write_room(tty) > 0)
>
>Any preferences?
>
>
Who should implement tty->stopped? AFAICS tty->stopped is implemented in
the drivers right now, and my patch would leave that unchanged.
--
Manfred
next prev parent reply other threads:[~2003-07-29 18:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-29 14:12 [PATCH] select fix Andries.Brouwer
2003-07-29 17:36 ` Andrew Morton
2003-07-29 17:48 ` Valdis.Kletnieks
2003-07-29 18:09 ` Manfred Spraul
2003-07-29 17:57 ` Manfred Spraul [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-07-29 19:58 Andries.Brouwer
2003-07-29 20:18 Andries.Brouwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F26B570.7020004@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=Andries.Brouwer@cwi.nl \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox