From: Jeff Garzik <jgarzik@pobox.com>
To: Andries.Brouwer@cwi.nl
Cc: B.Zolnierkiewicz@elka.pw.edu.pl, linux-kernel@vger.kernel.org,
torvalds@osdl.org
Subject: Re: Add identify decoding 4/4
Date: Wed, 06 Aug 2003 17:25:43 -0400 [thread overview]
Message-ID: <3F317257.9040807@pobox.com> (raw)
In-Reply-To: <UTC200308061351.h76Dp6413498.aeb@smtp.cwi.nl>
Andries.Brouwer@cwi.nl wrote:
> No. <linux/ide-identify.h> contains a lot of 1-line static inline
> functions, just readable names for current magic bit checks,
> and one big function ide_dump_identify_info() that is included as
>
> #ifdef IDE_IDENTIFY_DEBUG
Yes, I understand how the C pre-processor works, thanks ;-)
I know full well _why_ the big function is in the header; that doesn't
address my point: we don't need to be putting big functions in header
files. That's why libraries were invented :)
Jeff
next prev parent reply other threads:[~2003-08-06 21:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-06 13:51 Add identify decoding 4/4 Andries.Brouwer
2003-08-06 21:25 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-08-06 21:44 Andries.Brouwer
2003-08-07 22:11 ` Horst von Brand
2003-08-06 7:23 Andries.Brouwer
2003-08-06 12:19 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F317257.9040807@pobox.com \
--to=jgarzik@pobox.com \
--cc=Andries.Brouwer@cwi.nl \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox