Re: generic strncpy - off-by-one error

Daniel Forrest
2003-08-16T08:41:37Z

On Sat, Aug 16, 2003 at 10:15:14AM +0200, Peter Kjellerstedt wrote:
>
> Here is the code that I used:
>
> char *strncpy(char *dest, const char *src, size_t count)
> {
> char *tmp = dest;
>
> while (count && *src) {
> *tmp++ = *src++;
> count--;
> }
>
> if (count) {
> size_t count2;
>
> while (count & (sizeof(long) - 1)) {

Shouldn't this be:

while (tmp & (sizeof(long) - 1)) {

> *tmp++ = '\0';
> count--;
> }
>
> count2 = count / sizeof(long);
> while (count2) {
> *((long *)tmp)++ = '\0';
> count2--;
> }
>
> count &= (sizeof(long) - 1);
> while (count) {
> *tmp++ = '\0';
> count--;
> }
> }
>
> return dest;
> }

--
Dan