From: Jeff Garzik <jgarzik@pobox.com>
To: Matt Mackall <mpm@selenic.com>
Cc: James Morris <jmorris@intercode.com.au>,
"David S. Miller" <davem@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cryptoapi: Fix sleeping
Date: Wed, 13 Aug 2003 20:21:05 -0400 [thread overview]
Message-ID: <3F3AD5F1.8000901@pobox.com> (raw)
In-Reply-To: <20030813233957.GE325@waste.org>
Matt Mackall wrote:
> We need in_atomic() so that we can call from regions where preempt is
> disabled, for instance when using per_cpu crypto tfms.
>
> diff -urN -X dontdiff orig/crypto/internal.h work/crypto/internal.h
> --- orig/crypto/internal.h 2003-07-13 22:29:11.000000000 -0500
> +++ work/crypto/internal.h 2003-08-12 14:38:54.000000000 -0500
> @@ -37,7 +37,7 @@
>
> static inline void crypto_yield(struct crypto_tfm *tfm)
> {
> - if (!in_softirq())
> + if (!in_atomic())
> cond_resched();
Do you really want to schedule inside preempt_disable() ?
As an aside, I think it would be nice if cond_resched could figure out
for itself whether it is ok to schedule(). Completely eliminate the
above test entirely, moving it into cond_resched().
Jeff
next prev parent reply other threads:[~2003-08-14 0:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-13 23:39 [PATCH] cryptoapi: Fix sleeping Matt Mackall
2003-08-14 0:21 ` Jeff Garzik [this message]
2003-08-14 0:34 ` Robert Love
2003-08-14 1:58 ` Matt Mackall
2003-08-14 16:29 ` Robert Love
2003-08-14 16:33 ` Matt Mackall
2003-08-14 0:44 ` Andrew Morton
2003-08-14 2:03 ` Matt Mackall
2003-08-14 7:15 ` Matt Mackall
2003-08-14 17:08 ` James Morris
2003-08-14 20:18 ` Matt Mackall
2003-08-15 3:39 ` James Morris
2003-08-15 3:50 ` Matt Mackall
2003-08-15 4:07 ` James Morris
2003-08-14 1:54 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F3AD5F1.8000901@pobox.com \
--to=jgarzik@pobox.com \
--cc=davem@redhat.com \
--cc=jmorris@intercode.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox