From: Dominik.Strasser@t-online.de (Dominik Strasser)
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi.h uses "u8" which isn't defined.
Date: Sun, 17 Aug 2003 15:08:55 +0200 [thread overview]
Message-ID: <3F3F7E67.2040506@t-online.de> (raw)
In-Reply-To: <20030817134633.A7881@infradead.org>
Christoph Hellwig wrote:
> On Sun, Aug 17, 2003 at 02:42:20PM +0200, Dominik Strasser wrote:
>
>>scsi.h uses "u8" which doesn't seem to be defined.
>>Better use u_char.
>
>
> It's defined in <linux/types.h> as is u_char. But we generally prefer
> explicitly sized types in Linux - and u_char is a BSDism, the right
> not explicitly sized type would be unsigned char.
I am sorry, in 2.6.0-test3 (which I should have mentioned), there is no
u8 in liux/types.h. Just a __u8.
Nevertheless there is a mixture in scsi.h, some lines above, u_char is
used. This is why I chose to use it.
Dominik
next prev parent reply other threads:[~2003-08-17 13:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-17 12:42 [PATCH] scsi.h uses "u8" which isn't defined Dominik Strasser
2003-08-17 12:46 ` Christoph Hellwig
2003-08-17 13:08 ` Dominik Strasser [this message]
2003-08-17 13:07 ` Christoph Hellwig
2003-08-17 13:50 ` Dominik Strasser
2003-08-17 13:07 ` Muli Ben-Yehuda
2003-08-17 12:55 ` Muli Ben-Yehuda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F3F7E67.2040506@t-online.de \
--to=dominik.strasser@t-online.de \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox