Re: [PATCH] scsi.h uses "u8" which isn't defined.

Dominik Strasser
2003-08-17T13:43:26Z

Christoph Hellwig wrote:
> On Sun, Aug 17, 2003 at 03:08:55PM +0200, Dominik Strasser wrote:
>
>>I am sorry, in 2.6.0-test3 (which I should have mentioned), there is no
>>u8 in liux/types.h.
>
>
> u8 is defined in asm/types.h but the proper way to include asm/types.h
> is through linux/types.h.
>
>
>>Just a __u8.
>>Nevertheless there is a mixture in scsi.h, some lines above, u_char is
>>used. This is why I chose to use it.
>
>
> If you want consistency please convert all u_char to u8 (similar
> for u_short -> u16 and u_int -> u32)
>
>

OK, here we go:

--- /tmp/scsi.h 2003-08-17 14:39:42.000000000 +0200
+++ include/scsi/scsi.h 2003-08-17 15:46:27.000000000 +0200
@@ -6,6 +6,8 @@
* the scsi code for linux.
*/

+#include <linux/types.h>
+
/*
$Header: /usr/src/linux/include/linux/RCS/scsi.h,v 1.3 1993/09/24
12:20:33 drew Exp $

@@ -208,18 +210,18 @@

struct ccs_modesel_head
{
- u_char _r1; /* reserved */
- u_char medium; /* device-specific medium type */
- u_char _r2; /* reserved */
- u_char block_desc_length; /* block descriptor length */
- u_char density; /* device-specific density code */
- u_char number_blocks_hi; /* number of blocks in this block desc */
- u_char number_blocks_med;
- u_char number_blocks_lo;
- u_char _r3;
- u_char block_length_hi; /* block length for blocks in this desc */
- u_char block_length_med;
- u_char block_length_lo;
+ u8 _r1; /* reserved */
+ u8 medium; /* device-specific medium type */
+ u8 _r2; /* reserved */
+ u8 block_desc_length; /* block descriptor length */
+ u8 density; /* device-specific density code */
+ u8 number_blocks_hi; /* number of blocks in this block desc */
+ u8 number_blocks_med;
+ u8 number_blocks_lo;
+ u8 _r3;
+ u8 block_length_hi; /* block length for blocks in this desc */
+ u8 block_length_med;
+ u8 block_length_lo;
};

/*