Re: [PATCH] scsi.h uses "u8" which isn't defined.

Muli Ben-Yehuda
2003-08-17T12:55:39Z

[-- Attachment #1: Type: text/plain, Size: 1074 bytes --]

On Sun, Aug 17, 2003 at 02:42:20PM +0200, Dominik Strasser wrote:
> scsi.h uses "u8" which doesn't seem to be defined.
> Better use u_char.
>
> --- linux/include/scsi/scsi.h 2003-08-17 14:36:02.000000000 +0200
> +++ /tmp/scsi.h 2003-08-17 14:39:42.000000000 +0200
> @@ -226,7 +226,7 @@
> * ScsiLun: 8 byte LUN.
> */
> typedef struct scsi_lun {
> - u_char scsi_lun[8];
> + u8 scsi_lun[8];
> } ScsiLun;

IMO, it's more correct to include <linux/types.h> in scsi.h, which
will bring in u8 and make scsi.h compilable on its own (provided
__KERNEL__ is defined, as it should be).

Index: include/scsi/scsi.h
===================================================================
RCS file: /home/cvs/linux-2.5/include/scsi/scsi.h,v
retrieving revision 1.10
diff -u -r1.10 scsi.h
--- include/scsi/scsi.h 13 May 2003 06:20:05 -0000 1.10
+++ include/scsi/scsi.h 17 Aug 2003 11:23:01 -0000
@@ -14,6 +14,8 @@

*/

+#include <linux/types.h>
+
/*
* SCSI command lengths
*/

--
Muli Ben-Yehuda
http://www.mulix.org

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]