From: Steve Dickson <SteveD@redhat.com>
To: nfs@lists.sourceforge.net
Cc: linux-kernel <linux-kernel@vger.kernel.org>, acl-devel@bestbits.at
Subject: [NFS] [PATCH] Stop call_decode() from ignorning RPC header errrors
Date: Wed, 20 Aug 2003 13:34:52 -0400 [thread overview]
Message-ID: <3F43B13C.5010403@RedHat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 187 bytes --]
This patch stop call_decode() from ignoring errors
that are found while parsing the RPC header. I turns
out the nfs acls routines need these error codes to do
the right thing...
SteveD.
[-- Attachment #2: linux-2.4.21-sunrpc-calldecode.patch --]
[-- Type: text/plain, Size: 703 bytes --]
--- linux-2.4.21/net/sunrpc/clnt.c.diff 2003-08-18 11:11:22.000000000 -0400
+++ linux-2.4.21/net/sunrpc/clnt.c 2003-08-20 12:13:02.000000000 -0400
@@ -784,9 +784,16 @@ call_decode(struct rpc_task *task)
__FUNCTION__);
/* Verify the RPC header */
- if (!(p = call_verify(task)))
+ if (!(p = call_verify(task))) {
+ /*
+ * When call_verfiy sets tk_action to NULL (via task_exit)
+ * a non-retry-able error has occurred (like the server
+ * not supporting a particular procedure call).
+ */
+ if (task->tk_action == NULL)
+ return;
goto out_retry;
-
+ }
/*
* The following is an NFS-specific hack to cater for setuid
* processes whose uid is mapped to nobody on the server.
next reply other threads:[~2003-08-20 17:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-20 17:34 Steve Dickson [this message]
2003-08-20 19:09 ` [NFS] [PATCH] Stop call_decode() from ignorning RPC header errrors Trond Myklebust
2003-08-27 11:08 ` [Acl-Devel] " Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F43B13C.5010403@RedHat.com \
--to=steved@redhat.com \
--cc=acl-devel@bestbits.at \
--cc=linux-kernel@vger.kernel.org \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox