public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tupshin Harper <tupshin@tupshin.com>
To: Andries Brouwer <aebr@win.tue.nl>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>,
	Ulrich Drepper <drepper@redhat.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: NFS regression in 2.6 -- gnome problem
Date: Wed, 20 Aug 2003 17:28:03 -0700	[thread overview]
Message-ID: <3F441213.4060906@tupshin.com> (raw)
In-Reply-To: <20030820215246.B3065@pclin040.win.tue.nl>

Andries Brouwer wrote:

>It should be. But it isnt. I propose the following patch
>(with whitespace damage):
>
>diff -u --recursive --new-file -X /linux/dontdiff a/fs/nfs/dir.c b/fs/nfs/dir.c
>--- a/fs/nfs/dir.c      Fri Jul 11 00:35:26 2003
>+++ b/fs/nfs/dir.c      Wed Aug 20 22:38:42 2003
>@@ -671,8 +671,10 @@
>        dentry->d_op = &nfs_dentry_operations;
> 
>        /* If we're doing an exclusive create, optimize away the lookup */
>-       if (nfs_is_exclusive_create(dir, nd))
>+       if (nfs_is_exclusive_create(dir, nd)) {
>+               d_add(dentry, NULL);
>                return NULL;
>+       }
> 
>        lock_kernel();
>        error = nfs_cached_lookup(dir, dentry, &fhandle, &fattr);
>
>Andries
>
>  
>
This patch makes the previously posted test work for me, but I'm 
experiencing a differenct NFS regression between 2.4 and 2.6. Whatever 
locking method that gnome2 is using when running home directories over 
nfs is failing when the client is running 2.6. Tried it again, using 
2.6.0-test3 + the above patch, and the results are the same. Gnome 
reports that it failed to lock it's test file, and aborts. It says that 
the error was "no locks available", but I'm not sure whether to believe 
that or not. The only differece is booting between 2.4.x and 2.6.x, and 
it doesn't matter whether the server is running 2.4 or 2.6. Any suggestions?

-Tupshin


  parent reply	other threads:[~2003-08-21  0:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-19 18:13 NFS regression in 2.6 Ulrich Drepper
2003-08-19 18:49 ` Ulrich Drepper
2003-08-19 19:19   ` Tupshin Harper
2003-08-19 19:06 ` Andries Brouwer
2003-08-19 19:15   ` Ulrich Drepper
2003-08-20  2:26     ` Andries Brouwer
2003-08-20  5:37 ` Trond Myklebust
2003-08-20 17:24   ` Andries Brouwer
2003-08-20 18:43     ` Trond Myklebust
2003-08-20 19:02       ` Ulrich Drepper
2003-08-20 19:52       ` Andries Brouwer
2003-08-20 20:02         ` Trond Myklebust
2003-08-21  0:28         ` Tupshin Harper [this message]
2003-08-21  0:38           ` NFS regression in 2.6 -- gnome problem Andries Brouwer
2003-08-21  1:07             ` Tupshin Harper
2003-08-21  3:05         ` NFS regression in 2.6 Ulrich Drepper
2003-08-20 17:43   ` Ulrich Drepper
2003-08-20 18:06     ` Andries Brouwer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F441213.4060906@tupshin.com \
    --to=tupshin@tupshin.com \
    --cc=aebr@win.tue.nl \
    --cc=drepper@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox