From: Jeff Garzik <jgarzik@pobox.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: akpm@digeo.com
Subject: Re: [PATCH] missing io_apic.h inclusions
Date: Thu, 21 Aug 2003 10:22:19 -0400 [thread overview]
Message-ID: <3F44D59B.8040502@pobox.com> (raw)
In-Reply-To: <200308210912.h7L9CUtW029374@hera.kernel.org>
Linux Kernel Mailing List wrote:
> diff -Nru a/arch/i386/kernel/acpi/boot.c b/arch/i386/kernel/acpi/boot.c
> --- a/arch/i386/kernel/acpi/boot.c Thu Aug 21 02:12:34 2003
> +++ b/arch/i386/kernel/acpi/boot.c Thu Aug 21 02:12:34 2003
> @@ -34,6 +34,7 @@
> #if defined (CONFIG_X86_LOCAL_APIC)
> #include <mach_apic.h>
> #include <mach_mpparse.h>
> +#include <asm/io_apic.h>
> #endif
>
> #define PREFIX "ACPI: "
> diff -Nru a/arch/i386/kernel/setup.c b/arch/i386/kernel/setup.c
> --- a/arch/i386/kernel/setup.c Thu Aug 21 02:12:34 2003
> +++ b/arch/i386/kernel/setup.c Thu Aug 21 02:12:34 2003
> @@ -43,6 +43,7 @@
> #include <asm/setup.h>
> #include <asm/arch_hooks.h>
> #include <asm/sections.h>
> +#include <asm/io_apic.h>
> #include "setup_arch_pre.h"
> #include "mach_resources.h"
Well, the first change looks pretty wrong just given the config option.
And, too, this was the false "build fix". The correct build fix was
committed, and this patch was not needed at all. I'll grant that the
patch to setup.c does make sense, though, even if it's not strictly needed.
Jeff
parent reply other threads:[~2003-08-21 14:22 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <200308210912.h7L9CUtW029374@hera.kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F44D59B.8040502@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox