public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Matthew Wilcox <willy@debian.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
	linux-kernel@vger.kernel.org, Jens Axboe <axboe@suse.de>
Subject: Re: [PATCH] bio.c: reduce verbosity at boot
Date: Thu, 21 Aug 2003 11:19:07 -0400	[thread overview]
Message-ID: <3F44E2EB.6020508@pobox.com> (raw)
In-Reply-To: <20030821150211.GU19630@parcelfarce.linux.theplanet.co.uk>

Matthew Wilcox wrote:
> Linux is really far too verbose at boot time.  I don't think these messages
> add anything to either the end user experience or debug ability.
> 
> Index: fs/bio.c
> ===================================================================
> RCS file: /var/cvs/linux-2.6/fs/bio.c,v
> retrieving revision 1.2
> diff -u -p -r1.2 bio.c
> --- fs/bio.c	29 Jul 2003 17:25:49 -0000	1.2
> +++ fs/bio.c	21 Aug 2003 14:58:40 -0000
> @@ -793,10 +793,6 @@ static void __init biovec_init_pools(voi
>  					mempool_free_slab, bp->slab);
>  		if (!bp->pool)
>  			panic("biovec: can't init mempool\n");
> -
> -		printk("biovec pool[%d]: %3d bvecs: %3d entries (%d bytes)\n",
> -						i, bp->nr_vecs, pool_entries,
> -						size);


Although I agree with your "too verbose" sentiment above, I think the 
removing the messages outright might not serve the best interests the 
developer.  Since even KERN_DEBUG still spams dmesg, in these situations 
I usually change these type of messages to be conditionally printed iff 
a debug macro is enabled.

As a tangent, the huge x86 IO-APIC verbosity really bugs me, too, and 
often is the direct cause of useful early printk messages being lost 
before boot is even complete.

	Jeff




  reply	other threads:[~2003-08-21 15:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-21 15:02 [PATCH] bio.c: reduce verbosity at boot Matthew Wilcox
2003-08-21 15:19 ` Jeff Garzik [this message]
2003-08-21 16:51   ` Lou Langholtz
2003-08-21 19:37     ` Matthew Wilcox
2003-08-21 19:55       ` Linus Torvalds
2003-08-22  6:10         ` David Lang
2003-08-25 18:28         ` Jens Axboe
2003-08-21 20:31     ` Diego Calleja García
2003-08-22  1:11       ` Lou Langholtz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F44E2EB.6020508@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --cc=willy@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox