public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Sebastian Reichelt <Sebastian@tigcc.ticalc.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] VIA VT8231 router detection
Date: Sat, 30 Aug 2003 13:37:42 -0400	[thread overview]
Message-ID: <3F50E0E6.2040907@pobox.com> (raw)
In-Reply-To: <20030830151112.550df1a6.Sebastian@tigcc.ticalc.org>

Sebastian Reichelt wrote:
> Hello!
> 
> I have attached a trivial patch to the Linux 2.4.21 kernel (Debian
> unstable kernel-source-2.4.21 package version 2.4.21-5), to add support
> for "VIA Technologies, Inc. VT8231" as an interrupt router. I have also
> attached the output of lspci -vvv (not inline because of line breaks, is
> that OK?). Device 00:08.0, which did not have any IRQs assigned to it
> before, has gotten IRQ 9. I have used this patch for months without any
> problems, so it should be fine. Sorry if I have left out something
> important; please consider me a newbie.
[...]
> --- pci-irq.c.orig	2003-06-01 05:06:21.000000000 +0200
> +++ pci-irq.c	2003-08-30 00:17:42.000000000 +0200
> @@ -480,6 +480,7 @@
>  	{ "VIA", PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_0, pirq_via_get, pirq_via_set },
>  	{ "VIA", PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C596, pirq_via_get, pirq_via_set },
>  	{ "VIA", PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686, pirq_via_get, pirq_via_set },
> +	{ "VIA", PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_8231, pirq_via_get, pirq_via_set },
>  
>  	{ "OPTI", PCI_VENDOR_ID_OPTI, PCI_DEVICE_ID_OPTI_82C700, pirq_opti_get, pirq_opti_set },


Well, Mr. Newbie, your patch looks fine to me :)

I'll test it out locally, and make sure it gets into 2.4 and 2.6, if 
nobody beats me to it.

	Jeff




  reply	other threads:[~2003-08-30 17:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-30 13:11 [PATCH] VIA VT8231 router detection Sebastian Reichelt
2003-08-30 17:37 ` Jeff Garzik [this message]
2003-08-30 18:16   ` Sebastian Reichelt
2003-08-30 23:36     ` Mike Fedyk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F50E0E6.2040907@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=Sebastian@tigcc.ticalc.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox