Re: [PATCH] fix ppc ioremap prototype

Russell King
2003-09-04T07:32:35Z

On Thu, Sep 04, 2003 at 09:13:34AM +0200, Christoph Hellwig wrote:
> On Thu, Sep 04, 2003 at 10:33:57AM +1000, Paul Mackerras wrote:
> > I don't see why this is a problem. The change is compatible with the
> > existing uses. We need to be able to map 36-bit physical addresses on
> > 44x. What we really need now is 64-bit start/end values in struct
> > resource.
>
> Then add the phys_addr_t to all places where we deal with physical
> addresses, even if it's typedef'ed to unsigned long on all other
> arches and sane ppcs.

But phys_addr_t in struct resource and being passed into ioremap is
confusing. Apparantly, it isn't a physical address, but a platform
defined cookie which just happens to look like a physical address.

(or are we finally going to admit that it is a physical address?)

--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux