Re: [PATCH] fix ppc ioremap prototype

David S. Miller
2003-09-04T16:53:12Z

On Thu, 4 Sep 2003 09:41:37 -0700 (PDT)
Linus Torvalds <torvalds@osdl.org> wrote:

> No, I don't agree. The "iomem_resource" is there for all IO-mapped ranges,
> and it could easily be a mixture of PCI and other buses. In fact, it
> already is on bog-standard hardware: it contains the AGP windows etc.

Sure, but this model falls apart for things like I/O ports
and any other device access entity where one needs to use
special accessors to access stuff.

> So clearly ioremap() has to work for other buses too.

What if they are like I/O ports on x86 and require special
instructions to access?

> I think that in the 2.7.x timeframe, the right thing to do is definitely:
> - move towards using "struct resource" and "ioremap_resource()"
> - make resource sizes potentially be larger (ie use "u64" instead of
> "unsigned long")

Agreed.