Re: [PATCH] Re: Linux 2.6.0-test5

Mikael Pettersson
2003-09-09T10:35:41Z

Jeff Garzik writes:
> Note that people seeing "ifconfig down ... ifconfig up" problems need to
> apply this patch. (to 2.4.23-pre, too)
>
> Jeff
>
>
> diff -Nru a/net/core/dev.c b/net/core/dev.c
> --- a/net/core/dev.c Mon Sep 8 18:14:36 2003
> +++ b/net/core/dev.c Mon Sep 8 18:14:36 2003
> @@ -851,7 +851,11 @@
> * engine, but this requires more changes in devices. */
>
> smp_mb__after_clear_bit(); /* Commit netif_running(). */
> - netif_poll_disable(dev);
> + while (test_bit(__LINK_STATE_RX_SCHED, &dev->state)) {
> + /* No hurry. */
> + current->state = TASK_INTERRUPTIBLE;
> + schedule_timeout(1);
> + }

I independently discovered this bug in 2.4.23-pre3 last night,
where it caused my laptop to randomly lock up at suspends or
resumes. That may have been APM doing ifconfigs behind my
back, I don't know, all I got was a black screen :-(