Re: [2.6 patch] fix nfs4xdr.c compile warning

Adrian Bunk
2003-09-12T11:12:05Z

On Fri, Sep 12, 2003 at 12:40:39PM +1000, Neil Brown wrote:
>...
> > BTW:
> > Shouldn't the return values of nfsd4_encode_open{,_confirm,_downgrade}
> > be checked in the switch in nfsd4_encode_operation?
>
> No. There is nothing meaningful in their return values.

They return nfserr from ENCODE_SEQID_OP_TAIL.

If this isn't meaningful, should I send a patch that removes this return
from ENCODE_SEQID_OP_TAIL and changes these three functions to return
void?

> NeilBrown

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed