Re: [patch] 2.6.0-test5: serio config broken?

Adrian Bunk
2003-09-10T17:26:58Z

On Wed, Sep 10, 2003 at 08:55:42AM -0700, Tom Rini wrote:
>...
> > --- linux-2.6.0-test4-mm5-modular-no-smp/drivers/input/keyboard/Kconfig.old 2003-09-04 19:03:45.000000000 +0200
> > +++ linux-2.6.0-test4-mm5-modular-no-smp/drivers/input/keyboard/Kconfig 2003-09-04 19:04:49.000000000 +0200
> > @@ -13,7 +13,8 @@
> >
> > config KEYBOARD_ATKBD
> > tristate "AT keyboard support" if EMBEDDED || !X86
> > - default y
> > + default y if INPUT=y && INPUT_KEYBOARD=y && SERIO=y
> > + default m
> > depends on INPUT && INPUT_KEYBOARD && SERIO
> > help
> > Say Y here if you want to use a standard AT or PS/2 keyboard. Usually
> > --- linux-2.6.0-test5+tr-modular-no-smp/drivers/input/serio/Kconfig.old 2003-09-10 12:52:22.000000000 +0200
> > +++ linux-2.6.0-test5+tr-modular-no-smp/drivers/input/serio/Kconfig 2003-09-10 12:52:47.000000000 +0200
> > @@ -20,7 +20,8 @@
> >
> > config SERIO_I8042
> > tristate "i8042 PC Keyboard controller" if EMBEDDED || !X86
> > - default y
> > + default y if SERIO=y
> > + default m
> > depends on SERIO
> > ---help---
> > i8042 is the chip over which the standard AT keyboard and PS/2
>
> A slightly better fix is for SERIO to default to Y on X86 and to
> 'select SERIO_I8042 if X86'. Then have INPUT_KEYBOARD similarly select
> KEYBOARD_ATKBD.
>...

That wouldn't be needed. AFAIK there are _no_ problems if SERIO=y, the
select you suggest is already implemented the other way round.

If SERIO is always y if !EMBEDDED || X86 my patch wouldn't be needed.

Considering this, it seems the patch below is both the best and the
simplest solution for most users.

It doesn't obsolete the other patch since SERIO=m is still possible, but
makes it more unlikely to accidentially set SERIO=m (or even SERIO=n).

> Tom Rini

cu
Adrian

--- linux-2.6.0-test5+tr-modular-no-smp/drivers/input/serio/Kconfig.old 2003-09-10 19:02:01.000000000 +0200
+++ linux-2.6.0-test5+tr-modular-no-smp/drivers/input/serio/Kconfig 2003-09-10 19:02:29.000000000 +0200
@@ -2,7 +2,7 @@
# Input core configuration
#
config SERIO
- tristate "Serial i/o support (needed for keyboard and mouse)"
+ tristate "Serial i/o support (needed for keyboard and mouse)" if EMBEDDED || !X86
default y
---help---
Say Yes here if you have any input device that uses serial I/O to