sleeping function called from invalid context

sleeping function called from invalid context

[Samuel Flory]

  I'm seeing this on arjanv's 2.6.0-0.test4.1.33 kernel.

Debug: sleeping function called from invalid context at 
include/asm/uaccess.h:473
Call Trace:
 [<c011b7dd>] __might_sleep+0x5d/0x70
 [<c010d0ea>] save_v86_state+0x6a/0x200
 [<c010c8b5>] do_IRQ+0xd5/0x110
 [<c010acd2>] work_notifysig_v86+0x6/0x14
 [<c010ac7f>] syscall_call+0x7/0xb

Debug: sleeping function called from invalid context at 
include/asm/uaccess.h:473
Call Trace:
 [<c011b7dd>] __might_sleep+0x5d/0x70
 [<c010d0ea>] save_v86_state+0x6a/0x200
 [<c010bba0>] do_general_protection+0x0/0xb0
 [<c010acd2>] work_notifysig_v86+0x6/0x14
 [<c010ac7f>] syscall_call+0x7/0xb


  Any thoughts.  The system seems to function despite the issue.  It 
seems to have also occurred under 2.6.0-0.test3.1.31:
Aug 25 16:28:49 goblin kernel: Call Trace:
Aug 25 16:28:49 goblin kernel:  [<c011af2d>] __might_sleep+0x5d/0x70
Aug 25 16:28:49 goblin kernel:  [<c010d06a>] save_v86_state+0x6a/0x200
Aug 25 16:28:49 goblin kernel:  [<c010bb50>] do_general_protection+0x0/0xb0
Aug 25 16:28:49 goblin kernel:  [<c010ac82>] work_notifysig_v86+0x6/0x14
Aug 25 16:28:49 goblin kernel:  [<c010ac2f>] syscall_call+0x7/0xb
Aug 25 16:28:49 goblin kernel:
Aug 25 16:28:50 goblin kernel: Debug: sleeping function called from 
invalid cont
ext at include/asm/uaccess.h:473
Aug 25 16:28:50 goblin kernel: Call Trace:
Aug 25 16:28:50 goblin kernel:  [<c011af2d>] __might_sleep+0x5d/0x70
Aug 25 16:28:50 goblin kernel:  [<c010d06a>] save_v86_state+0x6a/0x200
Aug 25 16:28:50 goblin kernel:  [<c010bb50>] do_general_protection+0x0/0xb0
Aug 25 16:28:50 goblin kernel:  [<c010ac82>] work_notifysig_v86+0x6/0x14
Aug 25 16:28:50 goblin kernel:  [<c010ac2f>] syscall_call+0x7/0xb
Aug 25 16:28:50 goblin kernel:
Aug 25 16:28:51 goblin kernel: Debug: sleeping function called from 
invalid cont
ext at include/asm/uaccess.h:473
Aug 25 16:28:51 goblin kernel: Call Trace:
Aug 25 16:28:51 goblin kernel:  [<c011af2d>] __might_sleep+0x5d/0x70
Aug 25 16:28:51 goblin kernel:  [<c010d06a>] save_v86_state+0x6a/0x200
Aug 25 16:28:51 goblin kernel:  [<c010c865>] do_IRQ+0xd5/0x110
Aug 25 16:28:51 goblin kernel:  [<c010ac82>] work_notifysig_v86+0x6/0x14
Aug 25 16:28:51 goblin kernel:  [<c010ac2f>] syscall_call+0x7/0xb

-- 
Once you have their hardware. Never give it back.
(The First Rule of Hardware Acquisition)
Sam Flory  <sflory@rackable.com>

Re: sleeping function called from invalid context

[Matt Mackall]

On Tue, Sep 09, 2003 at 08:03:01AM -0700, Samuel Flory wrote:
>  I'm seeing this on arjanv's 2.6.0-0.test4.1.33 kernel.

> Debug: sleeping function called from invalid context at 
> include/asm/uaccess.h:473
> Call Trace:
> [<c011b7dd>] __might_sleep+0x5d/0x70
> [<c010d0ea>] save_v86_state+0x6a/0x200

It's a warning about the possibility of hitting a very old but rarely
hit bug, system should work the same as it always has despite the
warning. I'm working on this, but it's ugly. Hope to post a patch in
the next week or so.

-- 
Matt Mackall : http://www.selenic.com : of or relating to the moon

Re: sleeping function called from invalid context

[Samuel Flory]

Matt Mackall wrote:

>On Tue, Sep 09, 2003 at 08:03:01AM -0700, Samuel Flory wrote:
>  
>
>> I'm seeing this on arjanv's 2.6.0-0.test4.1.33 kernel.
>>    
>>
>
>  
>
>>Debug: sleeping function called from invalid context at 
>>include/asm/uaccess.h:473
>>Call Trace:
>>[<c011b7dd>] __might_sleep+0x5d/0x70
>>[<c010d0ea>] save_v86_state+0x6a/0x200
>>    
>>
>
>It's a warning about the possibility of hitting a very old but rarely
>hit bug, system should work the same as it always has despite the
>warning. I'm working on this, but it's ugly. Hope to post a patch in
>the next week or so.
>
>  
>

  That's good to know.  I was actually running for at least a on an 
older kernel before i noticed in in dmesg.

-- 
Once you have their hardware. Never give it back.
(The First Rule of Hardware Acquisition)
Sam Flory  <sflory@rackable.com>

Re: sleeping function called from invalid context

[Amit Virdi]

Hey Alan,

On 5/10/2011 3:02 PM, Alan Cox wrote:
>> On analysis, I found that this is due to the change introduced in
>> tty_ioctl.c where the termios mutex is taken to protect against
>> parallel throttle/unthrottle. Probably IrCOMM stack code wasn't
>> tested before merging this patch.
>>
>> Please suggest what should be done with the IrCOMM protocol stack
>> code to resolve this problem?
>
> It looks like the comments are wrong
>
>          /*
>           * Just give it over to the line discipline. There is no need to
>           * involve the flip buffers, since we are not running in an
>          interrupt
>           * handler
>           */
>
>
> appears to be completely untrue
>
> I suspect it just needs to use the tty_flip_buffer functions properly
> instead of trying to do clever shortcuts
>
>
> 	tty_insert_flip_string(self->tty, skb->data, skb->len);
> 	tty_flip_buffer_push(self->tty);
>
> .
>

I incorporated the change suggested by you and tested the stack again. 
It is working perfectly fine - no stack trace is printed now. I'll be 
sending the patch soon.

Thanks n Regards
Amit Virdi