From: Felipe W Damasio <felipewd@terra.com.br>
To: davem@redhat.com
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] Missing memory barrier on net/core/dev.c
Date: Tue, 09 Sep 2003 14:58:47 -0300 [thread overview]
Message-ID: <3F5E14D7.9030809@terra.com.br> (raw)
[-- Attachment #1: Type: text/plain, Size: 194 bytes --]
Hi Dave,
I *think* net/core/dev.c is missing a mb() before calling
schedule_timoeut.
Feel free to prove me wrong, though ;)
Patch against 2.6.0-test5.
Please review.
Cheers,
Felipe
[-- Attachment #2: net-core-current_state.patch --]
[-- Type: text/plain, Size: 475 bytes --]
--- linux-2.6.0-test5/net/core/dev.c Mon Sep 8 16:50:06 2003
+++ linux-2.6.0-test5-fwd/net/core/dev.c Tue Sep 9 14:52:48 2003
@@ -2753,9 +2753,9 @@
rebroadcast_time = jiffies;
}
- current->state = TASK_INTERRUPTIBLE;
+ set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(HZ / 4);
- current->state = TASK_RUNNING;
+ __set_current_state(TASK_RUNNING);
if (time_after(jiffies, warning_time + 10 * HZ)) {
printk(KERN_EMERG "unregister_netdevice: "
next reply other threads:[~2003-09-09 19:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-09 17:58 Felipe W Damasio [this message]
2003-09-09 19:46 ` [PATCH] Missing memory barrier on net/core/dev.c David S. Miller
2003-09-09 20:21 ` Felipe W Damasio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F5E14D7.9030809@terra.com.br \
--to=felipewd@terra.com.br \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox