From: Felipe W Damasio <felipewd@terra.com.br>
To: "David S. Miller" <davem@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Missing memory barrier on net/core/dev.c
Date: Tue, 09 Sep 2003 17:21:34 -0300 [thread overview]
Message-ID: <3F5E364E.2040409@terra.com.br> (raw)
In-Reply-To: <20030909124635.3c0d522b.davem@redhat.com>
Hi,
David S. Miller wrote:
> On Tue, 09 Sep 2003 14:58:47 -0300
> Felipe W Damasio <felipewd@terra.com.br> wrote:
>
>
>> I *think* net/core/dev.c is missing a mb() before calling
>>schedule_timoeut.
>
> I have another patch in my queue from Andrew Morton that
> removes the TASK_RUNNING setting altogether, schedule_timeout()
> always returns with the task in that state.
Ok, although that was not the main point of the patch :)
What about the "set_current_state" before calling schedule_timeout.
Isn't that mb() needed?
Cheers,
Felipe
prev parent reply other threads:[~2003-09-09 21:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-09 17:58 [PATCH] Missing memory barrier on net/core/dev.c Felipe W Damasio
2003-09-09 19:46 ` David S. Miller
2003-09-09 20:21 ` Felipe W Damasio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F5E364E.2040409@terra.com.br \
--to=felipewd@terra.com.br \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox