public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Kevin P. Fleming" <kpfleming@cox.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andreas Schwab <schwab@suse.de>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] new ioctl type checking causes gcc warning
Date: Fri, 12 Sep 2003 17:31:00 -0700	[thread overview]
Message-ID: <3F626544.40000@cox.net> (raw)
In-Reply-To: <200309130222.43612.arnd@arndb.de>

Arnd Bergmann wrote:

> This doesn't work, because size_t is a typedef, not a macro.

Yeah, I should have thought of that. Sorry.

> The type checking this in user space is not necessary, because 
> the point of the check is only to keep people from adding *new*
> invalid ioctl numbers and doing the check for the kernel does that.
> However, the old numbers need to be kept for a long time and there
> is no point in breaking user applications that use established
> interfaces.

Hmm, obviously I misunderstood how this worked. Does that mean that 
these two lines:

#define BLKGETSIZE64	_IOR(0x12,114,sizeof(__uint64_t))
#define BLKGETSIZE64	_IOR(0x12,114,__uint64_t)

actually produce different ioctl numbers? If so, then I don't 
understand how the kernel can continue to offer the old/invalid 
interface when the new _IOR macro won't accept the first version any 
longer.


  reply	other threads:[~2003-09-13  0:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-12 19:13 [PATCH] new ioctl type checking causes gcc warning Kevin P. Fleming
2003-09-12 20:02 ` Andreas Schwab
2003-09-12 12:53   ` Arnd Bergmann
2003-09-12 23:43     ` Kevin P. Fleming
2003-09-13  0:22       ` Arnd Bergmann
2003-09-13  0:31         ` Kevin P. Fleming [this message]
2003-09-13 11:05           ` Arnd Bergmann
2003-09-13 13:17             ` Kevin P. Fleming
2003-09-13 19:10       ` Jamie Lokier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F626544.40000@cox.net \
    --to=kpfleming@cox.net \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox