From: "Kevin P. Fleming" <kpfleming@cox.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andreas Schwab <schwab@suse.de>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] new ioctl type checking causes gcc warning
Date: Sat, 13 Sep 2003 06:17:03 -0700 [thread overview]
Message-ID: <3F6318CF.9030805@cox.net> (raw)
In-Reply-To: <200309131305.12161.arnd@arndb.de>
Arnd Bergmann wrote:
> Inside the kernel, the first definition has to be changed to
> something like:
>
> #define BLKGETSIZE64 _IOR(0x12,114,size_t) /* broken: actually __u64 */
> or
> #define BLKGETSIZE64 _IOR_BAD(0x12,114,sizeof(__uint64_t)) /* broken */
>
> in order to get a definition that will pass the check and
> generate the well-known number.
That's strange. I did some testing with a small application (blockdev)
that uses this ioctl yesterday, and strace did not show any difference
between the correct and incorrect definitions. I could change the
definition back and forth and the application continued to work
correctly. I'll have to go back and figure out what I was doing wrong :-)
next prev parent reply other threads:[~2003-09-13 13:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-12 19:13 [PATCH] new ioctl type checking causes gcc warning Kevin P. Fleming
2003-09-12 20:02 ` Andreas Schwab
2003-09-12 12:53 ` Arnd Bergmann
2003-09-12 23:43 ` Kevin P. Fleming
2003-09-13 0:22 ` Arnd Bergmann
2003-09-13 0:31 ` Kevin P. Fleming
2003-09-13 11:05 ` Arnd Bergmann
2003-09-13 13:17 ` Kevin P. Fleming [this message]
2003-09-13 19:10 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F6318CF.9030805@cox.net \
--to=kpfleming@cox.net \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox