public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Marcelo Tosatti <marcelo.tosatti@cyclades.com.br>,
	jgarzik@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.4 fix pci_generic_prep_mwi export breakage
Date: Sat, 20 Sep 2003 14:24:43 -0400	[thread overview]
Message-ID: <3F6C9B6B.4070308@pobox.com> (raw)
In-Reply-To: <200309171038.48602.bjorn.helgaas@hp.com>

Bjorn Helgaas wrote:
> I think the recent change to pci.c to export pci_generic_prep_mwi() 
> is incorrect.
> 
> pci_generic_prep_mwi() is only defined if !HAVE_ARCH_PCI_MWI,
> so it is wrong to export it.  In particular, it breaks on
> ia64, because we define HAVE_ARCH_PCI_MWI.
> 
> It looks to me like the following patch should be applied.  This
> removes the export and in fact makes pci_generic_prep_mwi() static
> as it is in 2.5.


Looks OK to me.  Marcelo applied this already, right?

	Jeff




  reply	other threads:[~2003-09-20 18:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-17 16:38 [PATCH] 2.4 fix pci_generic_prep_mwi export breakage Bjorn Helgaas
2003-09-20 18:24 ` Jeff Garzik [this message]
2003-09-21 18:28   ` Marcelo Tosatti
2003-09-22 16:07     ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F6C9B6B.4070308@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=bjorn.helgaas@hp.com \
    --cc=jgarzik@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox