From: Corey Minyard <cminyard@mvista.com>
To: "Robert T. Johnson" <rtjohnso@eecs.berkeley.edu>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.0-test6: more __init bugs
Date: Tue, 30 Sep 2003 04:42:25 -0500 [thread overview]
Message-ID: <3F795001.9020104@mvista.com> (raw)
In-Reply-To: <1064955628.5734.229.camel@dooby.cs.berkeley.edu>
Robert T. Johnson wrote:
>Here are some cases where __init code or data is referenced by
>non-__init code.
>
>Questions:
>- Is init_module allowed, required or forbidden to be __init?
>- Ditto for Scsi_Host_Template.detect()?
>- Ditto for net_device->set_config()?
>
>Thanks for looking at these potential bugs, and sorry if I've made
>any mistakes.
>
>Best,
>Rob
>
>P.S. All these bugs were found with Cqual, the bug-finding tool
>developed by Jeff Foster, John Kodumal, and many others, and available
>at http://www.cs.umd.edu/~jfoster/cqual/, although the currently
>released version of cqual only has primitive support for
>__init bug-finding.
>
>
>** Possible bug:
>** drivers/char/ipmi/ipmi_msghandler.c:ipmi_init_msghandler() (__init)
> called by numerous non-__init functions
>Note: ipmi_init_msghandler() is an alias for init_module
>Fix: declare ipmi_init_msghandler non-__init.
>
>
>
This is not actually a bug, but it may be bad style (and thus could lead
to a bug). It is possible that something that uses IPMI can do some
IPMI things before IPMI is initialized. This can only happen during
initialization, though. Thus the check; once IPMI is initialized the
function will never be called.
What's the opinion on this? Should I just force IPMI users to
initialize after IPMI?
Thanks,
-Corey
next prev parent reply other threads:[~2003-09-30 23:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-30 20:59 2.6.0-test6: more __init bugs Robert T. Johnson
2003-09-30 9:42 ` Corey Minyard [this message]
2003-10-01 0:02 ` Robert T. Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F795001.9020104@mvista.com \
--to=cminyard@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtjohnso@eecs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox