From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263543AbTJCOAz (ORCPT ); Fri, 3 Oct 2003 10:00:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263587AbTJCOAz (ORCPT ); Fri, 3 Oct 2003 10:00:55 -0400 Received: from natsmtp01.webmailer.de ([192.67.198.81]:51387 "EHLO natsmtp01.webmailer.de") by vger.kernel.org with ESMTP id S263543AbTJCOAx (ORCPT ); Fri, 3 Oct 2003 10:00:53 -0400 Message-ID: <3F7D817A.7020603@softhome.net> Date: Fri, 03 Oct 2003 16:02:34 +0200 From: "Ihar 'Philips' Filipau" Organization: Home Sweet Home User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20030927 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andries Brouwer CC: Linux Kernel Mailing List , "Eric W. Biederman" Subject: Re: [PATCH] linuxabi References: In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Andries Brouwer wrote: > > Possibly. So we need discussion. > > I have registered comment #1: Al prefers the enum style. > A possibility. > > Now you come with comment #2: write LINUX_MS_RDONLY instead of > MS_RDONLY. You have not convinced me. > My 0.02 euro. LINUX_* - not right stuff. It makes a lot of sence to have the same name for same thing, even in different contexts. Or you are going to create a hell for some-one who may wish to make a documentation. Headers are going to be used in different context (hopefully) so would be no collisions (hopefully). Another question does GCC have something like C++'s namespace for C? That's would be good. Changing names - bad. And #define LINUX_NS(x) doesn't make sound - you will lose ability to grep over defines and [ce]tags will not work on this anymore. cpp is not correct tool for namespace implementation. -- Ihar 'Philips' Filipau / with best regards from Saarbruecken. -- "... and for $64000 question, could you get yourself vaguely familiar with the notion of on-topic posting?" -- Al Viro @ LKML