public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steve Modica <modica@sgi.com>
To: linux-kernel@vger.kernel.org, modica@sgi.com
Subject: simple mod_timer patch
Date: Fri, 03 Oct 2003 16:31:43 -0500	[thread overview]
Message-ID: <3F7DEABF.2040606@sgi.com> (raw)

I pulled this back from the 2.6 kernel to reduce some serious contention on the 
timerlist_lock when I had 8 gigabit cards runnings.


diff -u -r1.23 -r1.24
--- linux/linux/kernel/timer.c       2003/08/11 20:16:19     1.23
+++ linux/linux/kernel/timer.c       2003/10/01 21:09:20     1.24
@@ -207,6 +207,14 @@
         int ret;
         unsigned long flags;

+        /*
+        * This is a common optimization triggered by the
+        * networking code - if the timer is re-modified
+        * to be the same thing then just return:
+        */
+        if (timer->expires == expires && timer_pending(timer))
+               return 1;
+
         spin_lock_irqsave(&timerlist_lock, flags);
         timer->expires = expires;
         ret = detach_timer(timer);



-- 
Steve Modica
work: 651-683-3224
MTS-Technical Lead
"Give a man a fish, and he will eat for a day, hit him with a fish and
he leaves you alone" - me


             reply	other threads:[~2003-10-03 21:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-03 21:31 Steve Modica [this message]
2003-10-03 21:32 ` simple mod_timer patch Steve Modica
2003-10-03 22:07 ` Andrew Morton
2003-10-06 15:22   ` Steve Modica

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F7DEABF.2040606@sgi.com \
    --to=modica@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox