Re: [RFC 0/6] Backing Store for sysfs

Dipankar Sarma
2003-10-06T17:59:16Z

On Mon, Oct 06, 2003 at 10:38:58AM -0700, Greg KH wrote:
> On Mon, Oct 06, 2003 at 11:01:11PM +0530, Dipankar Sarma wrote:
> > My guess is that those 24 dentries are just noise. What we should
> > do is verify with a large number of devices if the numbers are all
> > that different after a walk of the sysfs tree.
>
> Ok, a better test would be with a _lot_ of devices. Care to test with a
> lot of scsi debug devices?

Sure. At the same time, as Maneesh pointed out, this is just an
RFC. The backing store design probably needs quite some work first.

> > --------------------------------------------------------
> > After mounting sysfs
> > -------------------
> > dentry_cache (active) 2350 1321
> > inode_cache (active) 1058 31
> > LowFree 875096 KB 875836 KB
> > --------------------------------------------------------
> >
> > That saves ~800KB. If you just mount sysfs and use a few files, you
> > aren't eating up dentries and inodes for every file in sysfs. How often
> > do you expect hotplug events to happen in a system ?
>
> Every kobject that is created and is associated with a subsystem
> generates a hotplug call. So that's about every kobject that we care
> about here :)

That would not happen in a normal running system often, right ? So,
I don't see the point looking at mem usage after hotplug events.

>
> > Some time after a hotplug event, dentries/inodes will get aged out and
> > then you should see savings. It should greatly benefit in a normal
> > system.
>
> Can you show this happening?

It should be easy to demonstrate. That is how dentries/inodes
work for on-disk filesystems. If Maneesh's patch didn't work that
way, then the whole point is lost. I hope that is not the case.

>
> > Now if the additional kobjects cause problems with userland hotplug, then
> > that needs to be resolved. However that seems to be a different problem
> > altogether. Could you please elaborate on that ?
>
> No, I don't think the additional ones you have added will cause
> problems, but can you verify this? Just log all hotplug events
> happening in your system (point /proc/sys/kernel/hotplug to a simple
> logging program).
>
> But again, I don't think the added overhead you have added to a kobject
> is acceptable for not much gain for the normal case (systems without a
> zillion devices.)

IIRC, Maneesh test machine is a 2-way P4 xeon with six scsi disks and savings
are of about 800KB. That is as normal a case as it gets, I think.
It only gets better as you have more devices in your system.

Thanks
Dipankar