From: Jeff Garzik <jgarzik@pobox.com>
To: Matthew Wilcox <willy@debian.org>
Cc: Mark Haverkamp <markh@osdl.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] 2.6.0 aacraid driver update
Date: Mon, 06 Oct 2003 18:06:34 -0400 [thread overview]
Message-ID: <3F81E76A.10805@pobox.com> (raw)
In-Reply-To: <20031006215936.GF24824@parcelfarce.linux.theplanet.co.uk>
Matthew Wilcox wrote:
> On Mon, Oct 06, 2003 at 05:48:58PM -0400, Jeff Garzik wrote:
>
>>>+ /*
>>>+ * Yield the processor in case we are slow
>>>+ */
>>>+ set_current_state(TASK_UNINTERRUPTIBLE);
>>>+ schedule_timeout(1);
>>
>>hmmm... why not simply call yield() here instead? I think yield() is
>>closer to the intent you wish to achieve...
>
>
> Gods, no. I believe it is always a bug for drivers to call yield()
> in 2.6. What is probably meant here is cond_resched(). I'd support
> deleting the EXPORT_SYMBOL(yield) line and fixing the breakage afterwards
> as it causes lots of very subtle breakage ("Under certain circumstances,
> Linux just stops doing anything for 5 seconds").
Yes, you're right, and thank you for the correction. I was thinking
if (need_resched)
schedule();
which I incorrectly translated to yield() when searching my brain for
the 2.6 equivalent.
Jeff
prev parent reply other threads:[~2003-10-06 22:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1065475285.17021.79.camel@markh1.pdx.osdl.net>
[not found] ` <3F81E34A.1040201@pobox.com>
2003-10-06 21:59 ` [PATCH 3/3] 2.6.0 aacraid driver update Matthew Wilcox
2003-10-06 22:06 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F81E76A.10805@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=markh@osdl.org \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox