* 2.4.22-bk30 and C trigraphs bugs
@ 2003-10-08 23:44 Xose Vazquez Perez
2004-01-19 23:38 ` Randy.Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Xose Vazquez Perez @ 2003-10-08 23:44 UTC (permalink / raw)
To: linux-kernel
hi,
There are some mistakes with C trigraphs:
arch/m68k/atari/stram.c: PRINT_PROC( "??)\n" );
arch/sparc/kernel/traps.c: die_if_kernel("Penguin instruction from Penguin mode??!?!", regs);
drivers/atm/idt77252.c: printk("%s: PCI_COMMAND: %04x (???)\n",
drivers/acorn/scsi/acornscsi.c: "??-out", /* 1C */
drivers/acorn/scsi/acornscsi.c: "??-in", /* 1D */
drivers/block/acsi.c: { 0x00, "No error (??)" },
drivers/block/acsi.c: { 0x00, "No error (??)" },
drivers/media/video/saa7110.c: DEBUG(printk(KERN_INFO "unknown saa7110_command??(%d)\n",cmd));
drivers/mtd/maps/sun_uflash.c: name: "SUNW,???-????",
drivers/scsi/ppa.c: printk("ppa: parity error (???)\n");
drivers/scsi/ppa.c: printk("ppa: bad interrupt (???)\n");
drivers/scsi/imm.c: printk("imm: parity error (???)\n");
drivers/scsi/imm.c: printk("imm: bad interrupt (???)\n");
net/rose/af_rose.c: callsign = "??????-?";
fixes are trivial.
Is 2.6.0-pre free of them :-?
-thanks-
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: 2.4.22-bk30 and C trigraphs bugs
2003-10-08 23:44 2.4.22-bk30 and C trigraphs bugs Xose Vazquez Perez
@ 2004-01-19 23:38 ` Randy.Dunlap
2004-01-27 16:21 ` Xose Vazquez Perez
0 siblings, 1 reply; 3+ messages in thread
From: Randy.Dunlap @ 2004-01-19 23:38 UTC (permalink / raw)
To: Xose Vazquez Perez; +Cc: linux-kernel
On Thu, 09 Oct 2003 01:44:31 +0200 Xose Vazquez Perez <xose@wanadoo.es> wrote:
| hi,
|
| There are some mistakes with C trigraphs:
|
| arch/m68k/atari/stram.c: PRINT_PROC( "??)\n" );
| arch/sparc/kernel/traps.c: die_if_kernel("Penguin instruction from Penguin mode??!?!", regs);
| drivers/atm/idt77252.c: printk("%s: PCI_COMMAND: %04x (???)\n",
| drivers/acorn/scsi/acornscsi.c: "??-out", /* 1C */
| drivers/acorn/scsi/acornscsi.c: "??-in", /* 1D */
| drivers/block/acsi.c: { 0x00, "No error (??)" },
| drivers/block/acsi.c: { 0x00, "No error (??)" },
| drivers/media/video/saa7110.c: DEBUG(printk(KERN_INFO "unknown saa7110_command??(%d)\n",cmd));
| drivers/mtd/maps/sun_uflash.c: name: "SUNW,???-????",
| drivers/scsi/ppa.c: printk("ppa: parity error (???)\n");
| drivers/scsi/ppa.c: printk("ppa: bad interrupt (???)\n");
| drivers/scsi/imm.c: printk("imm: parity error (???)\n");
| drivers/scsi/imm.c: printk("imm: bad interrupt (???)\n");
| net/rose/af_rose.c: callsign = "??????-?";
|
| fixes are trivial.
|
| Is 2.6.0-pre free of them :-?
Of course not. I grepped over 100 of them in 2.6.1.
Are they a problem?
--
~Randy
kernel-janitors project: http://janitor.kernelnewbies.org/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: 2.4.22-bk30 and C trigraphs bugs
2004-01-19 23:38 ` Randy.Dunlap
@ 2004-01-27 16:21 ` Xose Vazquez Perez
0 siblings, 0 replies; 3+ messages in thread
From: Xose Vazquez Perez @ 2004-01-27 16:21 UTC (permalink / raw)
To: Randy.Dunlap; +Cc: linux-kernel
Randy.Dunlap wrote:
> On Thu, 09 Oct 2003 01:44:31 +0200 Xose Vazquez Perez <xose@wanadoo.es> wrote:
>
> | hi,
> |
> | There are some mistakes with C trigraphs:
> |
> | arch/m68k/atari/stram.c: PRINT_PROC( "??)\n" );
> | arch/sparc/kernel/traps.c: die_if_kernel("Penguin instruction from Penguin mode??!?!", regs);
> | drivers/atm/idt77252.c: printk("%s: PCI_COMMAND: %04x (???)\n",
> | drivers/acorn/scsi/acornscsi.c: "??-out", /* 1C */
> | drivers/acorn/scsi/acornscsi.c: "??-in", /* 1D */
> | drivers/block/acsi.c: { 0x00, "No error (??)" },
> | drivers/block/acsi.c: { 0x00, "No error (??)" },
> | drivers/media/video/saa7110.c: DEBUG(printk(KERN_INFO "unknown saa7110_command??(%d)\n",cmd));
> | drivers/mtd/maps/sun_uflash.c: name: "SUNW,???-????",
> | drivers/scsi/ppa.c: printk("ppa: parity error (???)\n");
> | drivers/scsi/ppa.c: printk("ppa: bad interrupt (???)\n");
> | drivers/scsi/imm.c: printk("imm: parity error (???)\n");
> | drivers/scsi/imm.c: printk("imm: bad interrupt (???)\n");
> | net/rose/af_rose.c: callsign = "??????-?";
> |
> | fixes are trivial.
> |
> | Is 2.6.0-pre free of them :-?
>
> Of course not. I grepped over 100 of them in 2.6.1.
>
> Are they a problem?
Visually yes, they hurt to the sight ;-)
But unless somebody uses -std or -ansi, by default GCC
ignores trigraphs.
--
Software is like sex, it's better when it's bug free.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-01-27 16:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-10-08 23:44 2.4.22-bk30 and C trigraphs bugs Xose Vazquez Perez
2004-01-19 23:38 ` Randy.Dunlap
2004-01-27 16:21 ` Xose Vazquez Perez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox