From: Jeff Garzik <jgarzik@pobox.com>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: Linus Torvalds <torvalds@osdl.org>,
viro@parcelfarce.linux.theplanet.co.uk,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] disable_irq()/enable_irq() semantics and ide-probe.c
Date: Thu, 09 Oct 2003 12:38:16 -0400 [thread overview]
Message-ID: <3F858EF8.5080105@pobox.com> (raw)
In-Reply-To: <3F858885.1070202@colorfullife.com>
Manfred Spraul wrote:
> I'd like to use that for nic shutdown for natsemi:
>
> disable_irq();
> shutdown_nic();
> free_irq();
> enable_irq();
Why not just shutdown the NIC inside spin_lock_irqsave or disable_irq,
and then free_irq separately?
If you can't stop the NIC hardware from generating interrupts, that's a
driver bug. And if the driver cannot handle its interrupt handler
between the spin_unlock_irqrestore() and free_irq() (shared irq case),
it's also buggy.
Jeff
next prev parent reply other threads:[~2003-10-09 16:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-09 16:10 [RFC] disable_irq()/enable_irq() semantics and ide-probe.c Manfred Spraul
2003-10-09 16:38 ` Jeff Garzik [this message]
2003-10-09 16:57 ` Benjamin Herrenschmidt
2003-10-09 17:03 ` Jeff Garzik
2003-10-09 17:07 ` Benjamin Herrenschmidt
2003-10-09 17:16 ` Jeff Garzik
2003-10-09 17:29 ` Linus Torvalds
2003-10-09 17:52 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2003-10-09 2:00 viro
2003-10-09 2:29 ` Linus Torvalds
2003-10-09 2:43 ` viro
2003-10-09 2:53 ` Linus Torvalds
2003-10-09 8:03 ` Russell King
2003-10-09 22:46 ` Zwane Mwaikambo
2003-10-09 8:07 ` Benjamin Herrenschmidt
2003-10-09 15:46 ` viro
2003-10-09 16:01 ` Linus Torvalds
2003-10-09 17:46 ` viro
2003-10-09 18:03 ` Linus Torvalds
2003-10-09 18:27 ` viro
2003-10-09 19:05 ` Linus Torvalds
2003-10-15 17:14 ` Anton Blanchard
2003-10-17 9:19 ` Russell King
2003-10-17 10:32 ` Benjamin Herrenschmidt
2003-10-09 12:55 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F858EF8.5080105@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=torvalds@osdl.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox