public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: mru@users.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: USB and DMA on Alpha with 2.6.0-test7
Date: Fri, 10 Oct 2003 13:15:54 -0700	[thread overview]
Message-ID: <3F87137A.5040807@pacbell.net> (raw)
In-Reply-To: <20031010225957.A764@den.park.msu.ru>

Ivan Kokshaysky wrote:
> 
> Sigh. The generic dma_* stuff wasn't a well thought-out idea,
> and it's too late to change it in 2.6. :-(

The API is more reasonable than the "all is PCI" assumption
from that "asm-generic" implementation.  I think it should be
reasonable to update any architecture's implementation there.


> Right now calling dma_* functions for non-busmaster devices
> just *doesn't work*.

See the patch I posted for dma_supported(), which should
make that one behave.  It's obvious how to generalize that
specific call with a platform_dma_supported().  USB won't
care about the other dma_* functions ... though it does suck
that all non-PCI ohci-hcd code still needs use the "fake PCI"
kluges.  (Proof that the implementation of those APIs is
still only usable with PCI.)

For other functions, it seems you're mostly saying that some
drivers are missing tests for non-null dma_mask pointers.


> David, do you mind applying that?

Yes, because that's nowhere near where the bugs are!
Also, it's good to get rid of BUG()s ... and better to
get rid of them when they're broken like that one is.

- Dave


  reply	other threads:[~2003-10-10 20:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-10 17:18 USB and DMA on Alpha with 2.6.0-test7 David Brownell
2003-10-10 18:19 ` Ivan Kokshaysky
2003-10-10 18:45   ` Måns Rullgård
2003-10-10 18:59     ` Ivan Kokshaysky
2003-10-10 20:15       ` David Brownell [this message]
2003-10-10 19:43 ` David Brownell
2003-10-11 13:27   ` Ivan Kokshaysky
2003-10-11 16:26     ` David Brownell
2003-10-11 23:03       ` David Brownell
  -- strict thread matches above, loose matches on Subject: below --
2003-10-10  9:22 Måns Rullgård
2003-10-10 10:47 ` Ivan Kokshaysky
2003-10-10 11:38   ` Måns Rullgård
2003-10-10 13:31   ` Jamie Lokier
2003-10-10 13:41     ` Ivan Kokshaysky
2003-10-10 16:41       ` Måns Rullgård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F87137A.5040807@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=ink@jurassic.park.msu.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mru@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox