From: Colin Ngam <cngam@sgi.com>
To: Jes Sorensen <jes@trained-monkey.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Patrick Gefre <pfg@sgi.com>,
linux-kernel@vger.kernel.org, davidm@napali.hpl.hp.com,
jbarnes@sgi.com
Subject: Re: [PATCH] Altix I/O code cleanup
Date: Thu, 16 Oct 2003 11:40:49 -0500 [thread overview]
Message-ID: <3F8ECA11.C4281A8C@sgi.com> (raw)
In-Reply-To: yq0brshwcrx.fsf@trained-monkey.org
Jes Sorensen wrote:
> >>>>> "Christoph" == Christoph Hellwig <hch@infradead.org> writes:
>
> >> ASSERT_ALWAYS checks it, it may not be pretty but it does check
> >> it.
>
> Christoph> No, it's useless. It's not different at all from just
> Christoph> derefencing a NULL pointer - both get you an oops.
Hi Christoph,
In the pointer case yes.
>
>
> I haven't looked at the place right there, however if the intention is
> to panic() on a failed kmalloc because the data structure is required
> for a core service, then doing ASSERT_ALWAYS isn't that unreasonable.
ASSERT_ALWAYS is used for many other cases other than just for
testing NULL Pointers. Whether you call ASSERT_ALWAYS or
call panic with a message or just allow it to oops, a descriptive panic
message can save some time.
Thanks.
colin
>
>
> Jes
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2003-10-16 17:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-10 21:49 [PATCH] Altix I/O code cleanup Patrick Gefre
2003-10-10 21:51 ` Jesse Barnes
2003-10-10 22:50 ` David Mosberger
2003-10-10 23:51 ` Jesse Barnes
2003-10-13 8:58 ` Christoph Hellwig
2003-10-13 10:55 ` Andrew Morton
2003-10-13 14:06 ` Christoph Hellwig
2003-10-13 8:56 ` Christoph Hellwig
2003-10-15 8:07 ` Jes Sorensen
2003-10-15 12:55 ` Christoph Hellwig
2003-10-16 13:08 ` Jes Sorensen
2003-10-16 16:40 ` Colin Ngam [this message]
2003-10-17 8:11 ` Christoph Hellwig
2003-10-17 13:36 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F8ECA11.C4281A8C@sgi.com \
--to=cngam@sgi.com \
--cc=davidm@napali.hpl.hp.com \
--cc=hch@infradead.org \
--cc=jbarnes@sgi.com \
--cc=jes@trained-monkey.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pfg@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).