From: Mike Christie <mikenc@us.ibm.com>
To: Aristeu Sergio Rozanski Filho <aris@cathedrallabs.org>
Cc: linux-kernel@vger.kernel.org, Brard Roudier <groudier@free.fr>
Subject: Re: [patch][1/3] qlogic: use scsi_host_alloc instead scsi_register
Date: Thu, 16 Oct 2003 14:34:51 -0700 [thread overview]
Message-ID: <3F8F0EFB.7090002@us.ibm.com> (raw)
In-Reply-To: <20031016015213.GA1765@cathedrallabs.org>
Aristeu Sergio Rozanski Filho wrote:
> --- linux/drivers/scsi/qlogicfas.c.orig 2003-10-15 23:41:52.000000000 -0200
> +++ linux/drivers/scsi/qlogicfas.c 2003-10-15 23:41:28.000000000 -0200
> @@ -671,7 +671,7 @@
> if (qlirq >= 0 && !request_irq(qlirq, do_ql_ihandl, 0, "qlogicfas", NULL))
> host->can_queue = 1;
> #endif
> - hreg = scsi_register(host, 0); /* no host data */
> + hreg = scsi_host_alloc(host, 0); /* no host data */
> if (!hreg)
I think this will break the non-PCMCIA version now. scsi_register also
adds the host to the template's legacy_hosts list. With your patch
init_this_scsi_driver will call the template's detect function then
never call scsi_add_host and scsi_scan_host because that list is empty.
Mike
next prev parent reply other threads:[~2003-10-16 21:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-16 1:52 [patch][1/3] qlogic: use scsi_host_alloc instead scsi_register Aristeu Sergio Rozanski Filho
2003-10-16 21:34 ` Mike Christie [this message]
2003-10-17 11:57 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F8F0EFB.7090002@us.ibm.com \
--to=mikenc@us.ibm.com \
--cc=aris@cathedrallabs.org \
--cc=groudier@free.fr \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox