public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <piggin@cyberone.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: Peter Osterlund <petero2@telia.com>,
	axboe@suse.de, linux-kernel@vger.kernel.org
Subject: Re: 2.6.0-test8, DEBUG_SLAB, oops in as_latter_request()
Date: Mon, 20 Oct 2003 10:25:37 +1000	[thread overview]
Message-ID: <3F932B81.2040202@cyberone.com.au> (raw)
In-Reply-To: <20031019142042.2f41eb68.akpm@osdl.org>



Andrew Morton wrote:

>Peter Osterlund <petero2@telia.com> wrote:
>
>>I was running 2.6.0-test8 compiled with CONFIG_DEBUG_SLAB=y. When
>> testing the CDRW packet writing driver, I got an oops in
>> as_latter_request. (Full oops at the end of this message.) It is
>> repeatable and happens because arq->rb_node.rb_right is uninitialized.
>>
>
>deadline seems to have the same problem.
>
>We may as well squish this with the big hammer?
>

Thanks for the report, Peter.

The request is a special request, so either blk_attempt_remerge should
never be called on it, or blk_attempt_remerge (or as_latter_request) should
check for this. Its up to Jens.

I would say to stick something like
if (!rq_mergeable(rq))
    return;

into blk_attempt_remerge.

I'd say we shouldn't expect drivers to try to get this right.


  reply	other threads:[~2003-10-20  0:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-19 19:54 2.6.0-test8, DEBUG_SLAB, oops in as_latter_request() Peter Osterlund
2003-10-19 21:20 ` Andrew Morton
2003-10-20  0:25   ` Nick Piggin [this message]
2003-10-20  7:09     ` Jens Axboe
2003-10-20  8:08       ` Nick Piggin
2003-10-20 19:37     ` Peter Osterlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F932B81.2040202@cyberone.com.au \
    --to=piggin@cyberone.com.au \
    --cc=akpm@osdl.org \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=petero2@telia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox