public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lars Knudsen <gandalf@revicon.com>
To: linux-kernel@vger.kernel.org, mufasa@sis.com.tw
Subject: SiS900 driver multicast problems and patch.
Date: Tue, 28 Oct 2003 09:40:12 +0100	[thread overview]
Message-ID: <3F9E2B6C.30000@revicon.com> (raw)

After upgrading to kernel 2.4.22 we discovered that multicast was no 
longer handled properly by the SiS900. Examining the changes between 
2.4.19 and 2.4.22 it is clear that the handling of multicast was changed 
but a bug was introduced.

A simple set_bit call from 2.4.19 was changed to the following:

u16 mc_filter[16] = {0};

unsigned int bit_nr =
         sis900_mcast_bitnr(mclist->dmi_addr, revision);
          mc_filter[bit_nr >> 4] |= (1 << bit_nr);

This will not work for bit_nr larger than 16 and hence the failure. 
Reverting to use set_bit causes multicast to be handled properly.

\Lars Knudsen

--- sis900.c    Mon Oct 27 17:49:36 2003
+++ sis900.c.orig       Mon Oct 27 17:48:52 2003
@@ -2101,8 +2101,9 @@
                rx_mode = RFAAB;
                for (i = 0, mclist = net_dev->mc_list; mclist && i < 
net_dev->mc_count;
                     i++, mclist = mclist->next) {
-                       set_bit(sis900_mcast_bitnr(mclist->dmi_addr, 
revision),
-                               mc_filter);
+                       unsigned int bit_nr =
+                               sis900_mcast_bitnr(mclist->dmi_addr, 
revision);
+                       mc_filter[bit_nr >> 4] |= (1 << bit_nr);
                }
        }



             reply	other threads:[~2003-10-28  8:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-28  8:40 Lars Knudsen [this message]
2003-10-28  9:17 ` SiS900 driver multicast problems and patch Måns Rullgård
2003-10-28  9:35   ` Lars Knudsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F9E2B6C.30000@revicon.com \
    --to=gandalf@revicon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mufasa@sis.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox