From: Chris Friesen <cfriesen@nortelnetworks.com>
To: mgross@linux.co.intel.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SMP signal latency fix up.
Date: Thu, 06 Nov 2003 18:26:34 -0500 [thread overview]
Message-ID: <3FAAD8AA.8060303@nortelnetworks.com> (raw)
In-Reply-To: 1068158989.3555.43.camel@localhost.localdomain
Mark Gross wrote:
> diff -urN -X dontdiff linux-2.6.0-test9/kernel/sched.c /opt/linux-2.6.0-test9/kernel/sched.c
> --- linux-2.6.0-test9/kernel/sched.c 2003-10-25 11:44:29.000000000 -0700
> +++ /opt/linux-2.6.0-test9/kernel/sched.c 2003-11-06 13:04:03.628116240 -0800
> @@ -626,13 +626,13 @@
> }
> success = 1;
> }
> -#ifdef CONFIG_SMP
> - else
> - if (unlikely(kick) && task_running(rq, p) && (task_cpu(p) != smp_processor_id()))
> - smp_send_reschedule(task_cpu(p));
> -#endif
> p->state = TASK_RUNNING;
> }
> +#ifdef CONFIG_SMP
> + else
> + if (unlikely(kick) && task_running(rq, p) && (task_cpu(p) != smp_processor_id()))
> + smp_send_reschedule(task_cpu(p));
> +#endif
> task_rq_unlock(rq, &flags);
Without any comment as to whether or not the patch would work, shouldn't
the "else" be moved back by a tab?
Chris
--
Chris Friesen | MailStop: 043/33/F10
Nortel Networks | work: (613) 765-0557
3500 Carling Avenue | fax: (613) 765-2986
Nepean, ON K2H 8E9 Canada | email: cfriesen@nortelnetworks.com
next prev parent reply other threads:[~2003-11-06 23:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-06 22:49 [PATCH] SMP signal latency fix up Mark Gross
2003-11-06 23:20 ` Linus Torvalds
2003-11-07 1:39 ` Mark Gross
2003-11-07 1:42 ` Mark Gross
2003-11-07 9:45 ` Ingo Molnar
2003-11-07 15:43 ` Mark Gross
2003-11-07 9:39 ` Ingo Molnar
2003-11-07 15:09 ` Linus Torvalds
2003-11-07 15:17 ` Ingo Molnar
2003-11-07 15:31 ` Ingo Molnar
2003-11-07 15:29 ` Ingo Molnar
2003-11-07 17:03 ` Mark Gross
2003-11-08 6:48 ` Ingo Molnar
2003-11-06 23:26 ` Chris Friesen [this message]
2003-11-06 23:35 ` Mark Gross
2003-11-07 0:55 ` Nuno Silva
2003-11-07 10:24 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2003-11-06 23:00 Mark Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FAAD8AA.8060303@nortelnetworks.com \
--to=cfriesen@nortelnetworks.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.co.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox