public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <piggin@cyberone.com.au>
To: Jens Axboe <axboe@suse.de>
Cc: linux-kernel@vger.kernel.org, ckrm-tech@lists.sourceforge.net
Subject: Re: [PATCH] cfq-prio #2
Date: Tue, 11 Nov 2003 01:16:14 +1100	[thread overview]
Message-ID: <3FAF9DAE.3070307@cyberone.com.au> (raw)
In-Reply-To: <20031110140052.GC32637@suse.de>



Jens Axboe wrote:

>Hi,
>
>

Hi Jens

>@@ -1553,6 +1559,10 @@
> 	struct io_context *ioc = get_io_context(gfp_mask);
> 
> 	spin_lock_irq(q->queue_lock);
>+
>+	if (!elv_may_queue(q, rw))
>+		goto out_lock;
>+
> 	if (rl->count[rw]+1 >= q->nr_requests) {
> 		/*
> 		 * The queue will fill after this allocation, so set it as
>@@ -1566,15 +1576,12 @@
> 		}
> 	}
> 
>-	if (blk_queue_full(q, rw)
>-			&& !ioc_batching(ioc) && !elv_may_queue(q, rw)) {
>

I know I hijacked elv_may_queue from you... any chance we could seperate
these so our schedulers can live in peace? ;)

Maybe my version should be called elv_force_queue?



  reply	other threads:[~2003-11-10 14:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-10 14:00 [PATCH] cfq-prio #2 Jens Axboe
2003-11-10 14:16 ` Nick Piggin [this message]
2003-11-10 14:23   ` Jens Axboe
2003-11-10 14:34     ` Nick Piggin
2003-11-10 14:39       ` Jens Axboe
2003-11-10 14:43         ` Nick Piggin
2003-11-10 14:44           ` Jens Axboe
2003-11-10 14:48             ` Nick Piggin
2003-11-10 14:52               ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3FAF9DAE.3070307@cyberone.com.au \
    --to=piggin@cyberone.com.au \
    --cc=axboe@suse.de \
    --cc=ckrm-tech@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox