public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Manfred Spraul <manfred@colorfullife.com>
To: Dave Jones <davej@redhat.com>
Cc: Petr Vandrovec <vandrove@vc.cvut.cz>, linux-kernel@vger.kernel.org
Subject: Re: EFAULT reading /dev/mem... - broken x86info
Date: Mon, 10 Nov 2003 18:17:37 +0100	[thread overview]
Message-ID: <3FAFC831.4090108@colorfullife.com> (raw)
In-Reply-To: <20031110165654.GS10144@redhat.com>

Dave Jones wrote:

>On Mon, Nov 10, 2003 at 05:50:25PM +0100, Manfred Spraul wrote:
> > It breaks either your app or your AGP driver - what's simpler to fix? 
> > I'm biased, because if you update the AGP driver, then I must figure out 
> > how to fix DEBUG_PAGEALLOC 8-)
>
>I'm not convinced changing agpgart is worth the pain.
>The only userspace app that actually grovels through the aperture
>in this way is the agpgart test code, so this shouldn't be an issue.
>  
>
You misunderstood my objection:
we cannot assume that every page is mapped in the kernel linear mapping:
- with DEBUG_PAGEALLOC, lots of pages are removed from the linear mapping
- even without it, all pages that are used for AGP are removed from the 
mapping.

Thus if something fails with DEBUG_PAGEALLOC, it will fail sometimes 
with AGP gart as well.

>I thought the DEBUG_PAGEALLOC stuff just unmapped pages that had been
>kmalloc'd ?  The area of memory we're trying to read those mptables from
>shouldn't be unmapped in the first place should they ? Confused.
>  
>
DEBUG_PAGEALLOC unmaps pages on kmem_cache_free and __free_pages(). The 
pages are mapped again during get_free_pages and kmem_cache_alloc.

0x86000 looks like a normal page - what guarantees that it's not used by 
the kernel?

--
    Manfred


  reply	other threads:[~2003-11-10 17:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-08 16:27 EFAULT reading /dev/mem... - broken x86info Petr Vandrovec
2003-11-10 13:55 ` Richard B. Johnson
2003-11-10 16:11 ` Dave Jones
2003-11-10 16:50   ` Manfred Spraul
2003-11-10 16:56     ` Dave Jones
2003-11-10 17:17       ` Manfred Spraul [this message]
2003-11-10 18:05         ` Petr Vandrovec
2003-11-10 18:59           ` Manfred Spraul
2003-11-10 19:36             ` Mika Penttilä
2003-11-10 19:47               ` Manfred Spraul
2003-11-10 20:24                 ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3FAFC831.4090108@colorfullife.com \
    --to=manfred@colorfullife.com \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vandrove@vc.cvut.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox