* [2.6 patch] give SATA its' own menu
@ 2003-10-26 0:15 Adrian Bunk
2003-10-26 1:11 ` Petr Vandrovec
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2003-10-26 0:15 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-kernel
Hi Jeff,
for an average user it's non-obvious to search for SATA support under
SCSI. The patch below moves SATA suport out of SCSI and gives it an own
menu below SCSI.
diffstat output:
drivers/scsi/Kconfig | 110 ++++++++++++++++++++++---------------------
1 files changed, 58 insertions(+), 52 deletions(-)
Please apply
Adrian
--- linux-2.6.0-test9/drivers/scsi/Kconfig.old 2003-10-26 01:46:49.000000000 +0200
+++ linux-2.6.0-test9/drivers/scsi/Kconfig 2003-10-26 01:53:29.000000000 +0200
@@ -403,58 +403,6 @@
To compile this driver as a module, choose M here: the
module will be called megaraid.
-config SCSI_SATA
- bool "Serial ATA (SATA) support"
- depends on SCSI && EXPERIMENTAL
- help
- This driver family supports Serial ATA host controllers
- and devices.
-
- If unsure, say N.
-
-config SCSI_SATA_SVW
- tristate "ServerWorks Frodo / Apple K2 SATA support (EXPERIMENTAL)"
- depends on SCSI_SATA && PCI && EXPERIMENTAL
- help
- This option enables support for Broadcom/Serverworks/Apple K2
- SATA support.
-
- If unsure, say N.
-
-config SCSI_ATA_PIIX
- tristate "Intel PIIX/ICH SATA support"
- depends on SCSI_SATA && PCI
- help
- This option enables support for ICH5 Serial ATA.
- If PATA support was enabled previously, this enables
- support for select Intel PIIX/ICH PATA host controllers.
-
- If unsure, say N.
-
-config SCSI_SATA_PROMISE
- tristate "Promise SATA support"
- depends on SCSI_SATA && PCI && EXPERIMENTAL
- help
- This option enables support for Promise Serial ATA.
-
- If unsure, say N.
-
-config SCSI_SATA_SIL
- tristate "Silicon Image SATA support"
- depends on SCSI_SATA && PCI && BROKEN
- help
- This option enables support for Silicon Image Serial ATA.
-
- If unsure, say N.
-
-config SCSI_SATA_VIA
- tristate "VIA SATA support"
- depends on SCSI_SATA && PCI && EXPERIMENTAL
- help
- This option enables support for VIA Serial ATA.
-
- If unsure, say N.
-
config SCSI_BUSLOGIC
tristate "BusLogic SCSI support"
depends on (PCI || ISA) && SCSI
@@ -1719,3 +1667,61 @@
source "drivers/scsi/pcmcia/Kconfig"
endmenu
+
+menu "Serial ATA (SATA) support"
+ depends on EXPERIMENTAL
+
+config SCSI_SATA
+ bool "Serial ATA (SATA) support"
+ depends on EXPERIMENTAL
+ select SCSI
+ help
+ This driver family supports Serial ATA host controllers
+ and devices.
+
+ If unsure, say N.
+
+config SCSI_SATA_SVW
+ tristate "ServerWorks Frodo / Apple K2 SATA support (EXPERIMENTAL)"
+ depends on SCSI_SATA && PCI && EXPERIMENTAL
+ help
+ This option enables support for Broadcom/Serverworks/Apple K2
+ SATA support.
+
+ If unsure, say N.
+
+config SCSI_ATA_PIIX
+ tristate "Intel PIIX/ICH SATA support"
+ depends on SCSI_SATA && PCI
+ help
+ This option enables support for ICH5 Serial ATA.
+ If PATA support was enabled previously, this enables
+ support for select Intel PIIX/ICH PATA host controllers.
+
+ If unsure, say N.
+
+config SCSI_SATA_PROMISE
+ tristate "Promise SATA support"
+ depends on SCSI_SATA && PCI && EXPERIMENTAL
+ help
+ This option enables support for Promise Serial ATA.
+
+ If unsure, say N.
+
+config SCSI_SATA_SIL
+ tristate "Silicon Image SATA support"
+ depends on SCSI_SATA && PCI && BROKEN
+ help
+ This option enables support for Silicon Image Serial ATA.
+
+ If unsure, say N.
+
+config SCSI_SATA_VIA
+ tristate "VIA SATA support"
+ depends on SCSI_SATA && PCI && EXPERIMENTAL
+ help
+ This option enables support for VIA Serial ATA.
+
+ If unsure, say N.
+
+endmenu
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] give SATA its' own menu
2003-10-26 0:15 [2.6 patch] give SATA its' own menu Adrian Bunk
@ 2003-10-26 1:11 ` Petr Vandrovec
2003-10-27 8:30 ` Holger Schurig
2003-11-10 17:58 ` Adrian Bunk
0 siblings, 2 replies; 6+ messages in thread
From: Petr Vandrovec @ 2003-10-26 1:11 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Jeff Garzik, linux-kernel
On Sun, Oct 26, 2003 at 02:15:54AM +0200, Adrian Bunk wrote:
> Hi Jeff,
>
> for an average user it's non-obvious to search for SATA support under
> SCSI. The patch below moves SATA suport out of SCSI and gives it an own
> menu below SCSI.
Will users know that they have to enable SCSI disk & cdrom support to get
it really to work?
Petr
> +config SCSI_SATA
> + bool "Serial ATA (SATA) support"
> + depends on EXPERIMENTAL
> + select SCSI
> + help
> + This driver family supports Serial ATA host controllers
> + and devices.
> +
> + If unsure, say N.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] give SATA its' own menu
2003-10-26 1:11 ` Petr Vandrovec
@ 2003-10-27 8:30 ` Holger Schurig
2003-11-10 17:58 ` Adrian Bunk
1 sibling, 0 replies; 6+ messages in thread
From: Holger Schurig @ 2003-10-27 8:30 UTC (permalink / raw)
To: linux-kernel
> Will users know that they have to enable SCSI disk & cdrom support to get
> it really to work?
> Petr
It will select SCSI automatically, see the "select SCSI" line.
>
>> +config SCSI_SATA
>> + bool "Serial ATA (SATA) support"
>> + depends on EXPERIMENTAL
>> + select SCSI
>> + help
>> + This driver family supports Serial ATA host controllers
>> + and devices.
>> +
>> + If unsure, say N.
If you don't want to select something automatically, you could do it with a
comment-to-the-user:
comment "Serial ATA needs SCSI support"
depends on !(SCSI && EXPERIMENTAL)
config SCSI_SATA
bool "Serial ATA (SATA) support"
depends on SCSI && EXPERIMENTAL
--
Try Linux 2.6 from BitKeeper for PXA2x0 CPUs at
http://www.mn-logistik.de/unsupported/linux-2.6/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] give SATA its' own menu
2003-10-26 1:11 ` Petr Vandrovec
2003-10-27 8:30 ` Holger Schurig
@ 2003-11-10 17:58 ` Adrian Bunk
2003-11-10 18:25 ` Jeff Garzik
1 sibling, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2003-11-10 17:58 UTC (permalink / raw)
To: Petr Vandrovec; +Cc: Jeff Garzik, linux-kernel
On Sun, Oct 26, 2003 at 02:11:46AM +0100, Petr Vandrovec wrote:
> On Sun, Oct 26, 2003 at 02:15:54AM +0200, Adrian Bunk wrote:
> > Hi Jeff,
> >
> > for an average user it's non-obvious to search for SATA support under
> > SCSI. The patch below moves SATA suport out of SCSI and gives it an own
> > menu below SCSI.
>
> Will users know that they have to enable SCSI disk & cdrom support to get
> it really to work?
I don't know the internals of the SATA driver, but this is unchanged
from the current dependencies.
If this is required, I can send a patch that adds disk an cdrom options
to SATA and select's the appropriate SCSI options.
> Petr
>
> > +config SCSI_SATA
> > + bool "Serial ATA (SATA) support"
> > + depends on EXPERIMENTAL
> > + select SCSI
> > + help
> > + This driver family supports Serial ATA host controllers
> > + and devices.
> > +
> > + If unsure, say N.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [2.6 patch] give SATA its' own menu
2003-11-10 17:58 ` Adrian Bunk
@ 2003-11-10 18:25 ` Jeff Garzik
2003-11-12 0:05 ` Adrian Bunk
0 siblings, 1 reply; 6+ messages in thread
From: Jeff Garzik @ 2003-11-10 18:25 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Petr Vandrovec, linux-kernel
Adrian Bunk wrote:
> I don't know the internals of the SATA driver, but this is unchanged
> from the current dependencies.
>
> If this is required, I can send a patch that adds disk an cdrom options
> to SATA and select's the appropriate SCSI options.
If you didn't mind, such a patch would be nice...
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] give SATA its' own menu
2003-11-10 18:25 ` Jeff Garzik
@ 2003-11-12 0:05 ` Adrian Bunk
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2003-11-12 0:05 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Petr Vandrovec, linux-kernel
On Mon, Nov 10, 2003 at 01:25:33PM -0500, Jeff Garzik wrote:
> Adrian Bunk wrote:
> >I don't know the internals of the SATA driver, but this is unchanged
> >from the current dependencies.
> >
> >If this is required, I can send a patch that adds disk an cdrom options
> >to SATA and select's the appropriate SCSI options.
>
>
> If you didn't mind, such a patch would be nice...
Below is a patch that gives SATA its' own menu, and additionally adds
options that select SCSI disc or cdrom support if enabled.
> Jeff
cu
Adrian
--- linux-2.6.0-test9/drivers/scsi/Kconfig.old 2003-11-12 00:45:34.000000000 +0100
+++ linux-2.6.0-test9/drivers/scsi/Kconfig 2003-11-12 01:02:11.000000000 +0100
@@ -1,3 +1,76 @@
+menu "Serial ATA (SATA) support"
+ depends on EXPERIMENTAL
+
+config SCSI_SATA
+ bool "Serial ATA (SATA) support"
+ depends on EXPERIMENTAL
+ select SCSI
+ help
+ This driver family supports Serial ATA host controllers
+ and devices.
+
+ If unsure, say N.
+
+config SCSI_SATA_DISC
+ tristate "SATA disk support"
+ depends on SCSI_SATA
+ select BLK_DEV_SD
+ help
+ This option enables support for SATA hard disks.
+
+config SCSI_SATA_CDROM
+ tristate "SATA CD-ROM support"
+ depends on SCSI_SATA
+ select BLK_DEV_SR
+ help
+ This option enables support for SATA CD-ROMs.
+
+config SCSI_SATA_SVW
+ tristate "ServerWorks Frodo / Apple K2 SATA support (EXPERIMENTAL)"
+ depends on SCSI_SATA && PCI && EXPERIMENTAL
+ help
+ This option enables support for Broadcom/Serverworks/Apple K2
+ SATA support.
+
+ If unsure, say N.
+
+config SCSI_ATA_PIIX
+ tristate "Intel PIIX/ICH SATA support"
+ depends on SCSI_SATA && PCI
+ help
+ This option enables support for ICH5 Serial ATA.
+ If PATA support was enabled previously, this enables
+ support for select Intel PIIX/ICH PATA host controllers.
+
+ If unsure, say N.
+
+config SCSI_SATA_PROMISE
+ tristate "Promise SATA support"
+ depends on SCSI_SATA && PCI && EXPERIMENTAL
+ help
+ This option enables support for Promise Serial ATA.
+
+ If unsure, say N.
+
+config SCSI_SATA_SIL
+ tristate "Silicon Image SATA support"
+ depends on SCSI_SATA && PCI && BROKEN
+ help
+ This option enables support for Silicon Image Serial ATA.
+
+ If unsure, say N.
+
+config SCSI_SATA_VIA
+ tristate "VIA SATA support"
+ depends on SCSI_SATA && PCI && EXPERIMENTAL
+ help
+ This option enables support for VIA Serial ATA.
+
+ If unsure, say N.
+
+endmenu
+
+
menu "SCSI device support"
config SCSI
@@ -403,58 +476,6 @@
To compile this driver as a module, choose M here: the
module will be called megaraid.
-config SCSI_SATA
- bool "Serial ATA (SATA) support"
- depends on SCSI && EXPERIMENTAL
- help
- This driver family supports Serial ATA host controllers
- and devices.
-
- If unsure, say N.
-
-config SCSI_SATA_SVW
- tristate "ServerWorks Frodo / Apple K2 SATA support (EXPERIMENTAL)"
- depends on SCSI_SATA && PCI && EXPERIMENTAL
- help
- This option enables support for Broadcom/Serverworks/Apple K2
- SATA support.
-
- If unsure, say N.
-
-config SCSI_ATA_PIIX
- tristate "Intel PIIX/ICH SATA support"
- depends on SCSI_SATA && PCI
- help
- This option enables support for ICH5 Serial ATA.
- If PATA support was enabled previously, this enables
- support for select Intel PIIX/ICH PATA host controllers.
-
- If unsure, say N.
-
-config SCSI_SATA_PROMISE
- tristate "Promise SATA support"
- depends on SCSI_SATA && PCI && EXPERIMENTAL
- help
- This option enables support for Promise Serial ATA.
-
- If unsure, say N.
-
-config SCSI_SATA_SIL
- tristate "Silicon Image SATA support"
- depends on SCSI_SATA && PCI && BROKEN
- help
- This option enables support for Silicon Image Serial ATA.
-
- If unsure, say N.
-
-config SCSI_SATA_VIA
- tristate "VIA SATA support"
- depends on SCSI_SATA && PCI && EXPERIMENTAL
- help
- This option enables support for VIA Serial ATA.
-
- If unsure, say N.
-
config SCSI_BUSLOGIC
tristate "BusLogic SCSI support"
depends on (PCI || ISA) && SCSI
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2003-11-12 0:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-10-26 0:15 [2.6 patch] give SATA its' own menu Adrian Bunk
2003-10-26 1:11 ` Petr Vandrovec
2003-10-27 8:30 ` Holger Schurig
2003-11-10 17:58 ` Adrian Bunk
2003-11-10 18:25 ` Jeff Garzik
2003-11-12 0:05 ` Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox