From: Nick Piggin <piggin@cyberone.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: "Ramón Rey Vicente" <ramon.rey@hispalinux.es>,
linux-kernel@vger.kernel.org
Subject: Re: [2.6.0-test9-mm2] Badness in as_put_request at drivers/block/as-iosched.c:1783
Date: Tue, 11 Nov 2003 12:20:08 +1100 [thread overview]
Message-ID: <3FB03948.7090203@cyberone.com.au> (raw)
In-Reply-To: <20031110140451.2b5db433.akpm@osdl.org>
Andrew Morton wrote:
>Ramón Rey Vicente <ramon.rey@hispalinux.es> wrote:
>
>>Hi.
>>
>>Trying to scan de ide-scsi devices of my system, I get this
>>
>>arq->state 4
>>Badness in as_put_request at drivers/block/as-iosched.c:1783
>>Call Trace:
>> [<c01dc908>] as_put_request+0x48/0xa0
>> [<c01d47d3>] elv_put_request+0x13/0x20
>> [<c01d69f2>] __blk_put_request+0x52/0xa0
>> [<c01d6a61>] blk_put_request+0x21/0x40
>> [<c01d9d0e>] sg_io+0x2ee/0x440
>> [<c01da5c0>] scsi_cmd_ioctl+0x3c0/0x480
>> [<c0124b49>] update_process_times+0x29/0x40
>> [<c011949c>] schedule+0x31c/0x620
>> [<d093bb65>] cdrom_ioctl+0x25/0xd60 [cdrom]
>> [<c012eb33>] do_clock_nanosleep+0x1b3/0x300
>> [<c0119800>] default_wake_function+0x0/0x20
>> [<c01d86fa>] blkdev_ioctl+0x7a/0x383
>> [<c01584be>] block_ioctl+0x1e/0x40
>> [<c016158f>] sys_ioctl+0xef/0x260
>> [<c0257c57>] syscall_call+0x7/0xb
>>
>
>It looks to me that a simple set_request()/put_request() will always do
>this.
>
>Nick?
>
Yes. I suppose just add a check for PRESCHED there as well. This
actually can happen in ll_rw_blk.c as well and its pretty hard to
change.
next prev parent reply other threads:[~2003-11-11 1:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-10 21:35 [2.6.0-test9-mm2] Badness in as_put_request at drivers/block/as-iosched.c:1783 Ramón Rey Vicente
2003-11-10 22:04 ` Andrew Morton
2003-11-11 1:20 ` Nick Piggin [this message]
2003-11-11 0:42 ` Gerardo Exequiel Pozzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FB03948.7090203@cyberone.com.au \
--to=piggin@cyberone.com.au \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ramon.rey@hispalinux.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox