From: Jeff Garzik <jgarzik@pobox.com>
To: Prasanna Meda <pmeda@akamai.com>
Cc: Andrew Morton <akpm@osdl.org>,
tulip-users@lists.sourceforge.net, linux-kernel@vger.kernel.org,
linux-net@vger.kernel.org, danner@akamai.com,
bmancuso@akamai.com
Subject: Re: Poss. bug in tulip driver since 2.4.7
Date: Wed, 12 Nov 2003 23:34:48 -0500 [thread overview]
Message-ID: <3FB309E8.4080408@pobox.com> (raw)
In-Reply-To: <3FB29377.796E7C6A@akamai.com>
Prasanna Meda wrote:
> No, you need to bring the for loop outside the loop.
> - Otherwise we need to reset the setup_frame to
> tp->setup_frame after every loop.
> - You do not need to set the setup_frm for every
> mc address, we can set once after the complete
> has_table is ready.
> And also the 2.4 code missed a bit in tx_flags.
>
> We did the following change that makes it identical
> to 2.2 tulip driver, and it worked.
>
> --- Linux/drivers/net/tulip/tulip_core.c Fri Oct 10 20:22:29 2003
> +++ linux/drivers/net/tulip/tulip_core.c Fri Oct 10 20:28:19 2003
Yeah, that looks better... I'll give it a quick test locally, then push
it to Linus.
Jeff
prev parent reply other threads:[~2003-11-13 4:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-12 0:47 Poss. bug in tulip driver since 2.4.7 Prasanna Meda
2003-11-12 2:54 ` Andrew Morton
2003-11-12 3:51 ` Jeff Garzik
2003-11-12 20:09 ` Prasanna Meda
2003-11-13 4:34 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FB309E8.4080408@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=bmancuso@akamai.com \
--cc=danner@akamai.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=pmeda@akamai.com \
--cc=tulip-users@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox