public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kai Bankett <kbankett@aol.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] irq_balance does not make sense with HT but single physical CPU
Date: Wed, 26 Nov 2003 15:16:40 +0100	[thread overview]
Message-ID: <3FC4B5C8.6020405@aol.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 285 bytes --]

Hi @all,

this patch should disable irq_balance threat in case of only one 
installed physical cpu thats running in HyperThreading-mode (so reported 
as 2 cpus).
I think it should make no sense to run irq_blanance in that special case 
- please correct me if i´m wrong.

Thanks,

Kai


[-- Attachment #1.2: 2.6.0-test10-io_apic.diff --]
[-- Type: text/plain, Size: 689 bytes --]

diff -u -r -N linux-2.6.0-test10/arch/i386/kernel/io_apic.c linux-2.6.0-test10-kai/arch/i386/kernel/io_apic.c
--- linux-2.6.0-test10/arch/i386/kernel/io_apic.c	2003-11-24 02:31:38.000000000 +0100
+++ linux-2.6.0-test10-kai/arch/i386/kernel/io_apic.c	2003-11-26 14:30:29.000000000 +0100
@@ -627,6 +627,16 @@
 		irqbalance_disabled = 1;
 		return 0;
 	}
+
+#ifdef CONFIG_X86_HT
+	/* On Hyper-Threading CPUs - if only one physical installed
+	   balance does not make sense */
+	if (cpu_has_ht && smp_num_siblings == 2 && num_online_cpus() == 2) {
+		irqbalance_disabled = 1;
+		return 0;
+	}
+#endif
+
 	/*
 	 * Enable physical balance only if more than 1 physical processor
 	 * is present

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/x-pkcs7-signature, Size: 3411 bytes --]

             reply	other threads:[~2003-11-26 14:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-26 14:16 Kai Bankett [this message]
2003-11-26 15:46 ` [PATCH] irq_balance does not make sense with HT but single physical CPU Zwane Mwaikambo
2003-11-26 16:32   ` Kai Bankett
2003-11-26 17:09     ` Zwane Mwaikambo
2003-11-26 18:40 ` Jamie Lokier
2003-11-27  8:48   ` Kai Bankett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3FC4B5C8.6020405@aol.com \
    --to=kbankett@aol.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox