From: Paul Menage <menage@google.com>
To: Andi Kleen <ak@suse.de>
Cc: "Yu, Luming" <luming.yu@intel.com>,
linux-kernel@vger.kernel.org, acpi-devel@lists.sourceforge.net
Subject: Re: [ACPI] ACPI global lock macros
Date: Thu, 11 Dec 2003 00:27:54 -0800 [thread overview]
Message-ID: <3FD82A8A.9050307@google.com> (raw)
In-Reply-To: <20031211090716.0c3662d3.ak@suse.de>
Andi Kleen wrote:
>
> It has even more bugs, e.g. it doesn't tell gcc that GLptr is modified (this hurts with
> newer versions that optimize more aggressively)
GLptr itself isn't modified - *GLptr is, but none of the actual C code
accesses *GLptr, so how does this affect the compiler's optimization
efforts? Is it because gcc treats the call as a pure function that maps
a pointer to an acquired value, and hence believes that it can move it
around? There aren't any instances of ACPI_ACQUIRE_GLOBAL_LOCK being
called twice in the same function, so it wouldn't be able to cache a
result. But I agree that it ought to declare that it clobbers memory.
Paul
next prev parent reply other threads:[~2003-12-11 8:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-11 7:06 [ACPI] ACPI global lock macros Yu, Luming
2003-12-11 8:07 ` Andi Kleen
2003-12-11 8:27 ` Paul Menage [this message]
2003-12-11 8:20 ` Paul Menage
-- strict thread matches above, loose matches on Subject: below --
2003-12-11 7:27 Yu, Luming
2003-12-11 17:46 ` Nate Lawson
2003-12-09 18:20 Grover, Andrew
2003-12-09 19:04 ` Paul Menage
2003-12-09 19:03 ` David Mosberger
2003-12-09 9:22 Paul Menage
2003-12-10 7:45 ` [ACPI] " Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FD82A8A.9050307@google.com \
--to=menage@google.com \
--cc=acpi-devel@lists.sourceforge.net \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luming.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox