public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Hunold <hunold@convergence.de>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: marcelo.tosatti@cyclades.com
Subject: [PATCH][2.4] change two annoying messages from framebuffer drivers
Date: Fri, 12 Dec 2003 13:57:47 +0100	[thread overview]
Message-ID: <3FD9BB4B.6040900@convergence.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 696 bytes --]

Hello,

the Linux-on-a-CD system Knoppix has nearly all framebuffer drivers for 
2.4.23 compiled in. Additionally, it surpreesses most kernel messages by 
lowering the kernel log level.

Two framebuffer drivers (clgenfb.c and hgafb.c), however, use KERN_ERR 
to say that their particular card has *not* been found which is very 
annoying.

Especially the clgenfb.c driver simply says on bootup:
 >  Couldn't find PCI device
which can really confuse newbie users.

The appended patch replaces two KERN_ERR with KERN_INFO and additionally 
makes the clgen.c message more descriptive.

Please apply, thanks!

I'll create a separate patch 2.6 later, apparently clgenfb.c has gone there.

CU
Michael.

[-- Attachment #2: video-fb-shutup.diff --]
[-- Type: text/plain, Size: 967 bytes --]

diff -ur xx-linux-2.4.22/drivers/video/clgenfb.c xx-linux-2.4.22.p/drivers/video/clgenfb.c
--- xx-linux-2.4.22/drivers/video/clgenfb.c	2003-06-13 16:51:37.000000000 +0200
+++ xx-linux-2.4.22.p/drivers/video/clgenfb.c	2003-12-12 13:48:34.000000000 +0100
@@ -2547,7 +2547,7 @@
 
 	pdev = clgen_pci_dev_get (btype);
 	if (!pdev) {
-		printk (KERN_ERR " Couldn't find PCI device\n");
+		printk (KERN_INFO "clgen: couldn't find Cirrus Logic PCI device\n");
 		DPRINTK ("EXIT, returning 1\n");
 		return 1;
 	}
diff -ur xx-linux-2.4.22/drivers/video/hgafb.c xx-linux-2.4.22.p/drivers/video/hgafb.c
--- xx-linux-2.4.22/drivers/video/hgafb.c	2001-11-12 18:46:25.000000000 +0100
+++ xx-linux-2.4.22.p/drivers/video/hgafb.c	2003-12-12 13:47:01.000000000 +0100
@@ -704,7 +704,7 @@
 int __init hgafb_init(void)
 {
 	if (! hga_card_detect()) {
-		printk(KERN_ERR "hgafb: HGA card not detected.\n");
+		printk(KERN_INFO "hgafb: HGA card not detected.\n");
 		return -EINVAL;
 	}
 

             reply	other threads:[~2003-12-12 12:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-12 12:57 Michael Hunold [this message]
2003-12-15 10:10 ` [PATCH][2.4] change two annoying messages from framebuffer drivers Geert Uytterhoeven
2003-12-18 19:05   ` Marcelo Tosatti
2003-12-22 20:39     ` Michael Hunold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3FD9BB4B.6040900@convergence.de \
    --to=hunold@convergence.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox