From: Jeff Garzik <jgarzik@pobox.com>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
linux-net@vger.kernel.org, linux-kernel@vger.kernel.org,
Rik van Riel <riel@surriel.com>,
linux-tr@linuxtr.net, jschlst@samba.org, cgoos@syskonnect.de,
mid@auk.cx, phillim@amtrak.com, jochen@scram.de
Subject: Re: [PATCH][TRIVIAL] dep_tristate wants 3 arguments (fwd)
Date: Fri, 12 Dec 2003 17:34:19 -0500 [thread overview]
Message-ID: <3FDA426B.1060508@pobox.com> (raw)
In-Reply-To: <20031212222655.GH1825@fs.tum.de>
Adrian Bunk wrote:
> Hi Marcelo,
>
> the trivial patch by Rik forwarded below still applies against
> 2.4.24-pre1.
>
> Please apply
Let's not and say we did :)
> ----- Forwarded message from Rik van Riel <riel@surriel.com> -----
>
> Date: Mon, 13 Oct 2003 11:10:36 -0400 (EDT)
> From: Rik van Riel <riel@surriel.com>
> To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
> Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>
> Subject: [PATCH][TRIVIAL] dep_tristate wants 3 arguments
>
> The tokenring Config.in has dep_tristate statements with only two
> arguments. Add the obvious third argument.
>
> diff -urNp linux-5110/drivers/net/tokenring/Config.in linux-10010/drivers/net/tokenring/Config.in
> --- linux-5110/drivers/net/tokenring/Config.in
> +++ linux-10010/drivers/net/tokenring/Config.in
> @@ -21,10 +21,10 @@ if [ "$CONFIG_TR" != "n" ]; then
> dep_tristate ' 3Com 3C359 Token Link Velocity XL adapter support' CONFIG_3C359 $CONFIG_TR $CONFIG_PCI
> tristate ' Generic TMS380 Token Ring ISA/PCI adapter support' CONFIG_TMS380TR
> if [ "$CONFIG_TMS380TR" != "n" ]; then
> - dep_tristate ' Generic TMS380 PCI support' CONFIG_TMSPCI $CONFIG_PCI
> - dep_tristate ' Generic TMS380 ISA support' CONFIG_TMSISA $CONFIG_ISA
> - dep_tristate ' Madge Smart 16/4 PCI Mk2 support' CONFIG_ABYSS $CONFIG_PCI
> - dep_tristate ' Madge Smart 16/4 Ringnode MicroChannel' CONFIG_MADGEMC $CONFIG_MCA
> + dep_tristate ' Generic TMS380 PCI support' CONFIG_TMSPCI $CONFIG_PCI $CONFIG_TMS380TR
> + dep_tristate ' Generic TMS380 ISA support' CONFIG_TMSISA $CONFIG_ISA $CONFIG_TMS380TR
> + dep_tristate ' Madge Smart 16/4 PCI Mk2 support' CONFIG_ABYSS $CONFIG_PCI $CONFIG_TMS380TR
> + dep_tristate ' Madge Smart 16/4 Ringnode MicroChannel' CONFIG_MADGEMC $CONFIG_MCA $CONFIG_TMS380TR
I don't see why this patch is needed.
dep_tristate statements with only three arguments (include desc. text)
are just fine. There is no need for additional arguments.
dep_tristate 'blah blah' CONFIG_BLAH dep...
Further, adding CONFIG_TMS380TR dependency is complete nonsense,
considering that the "if [ "$CONFIG_TMS380TR" != "n" ]" check remains.
Jeff
next prev parent reply other threads:[~2003-12-12 22:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-12 22:26 [PATCH][TRIVIAL] dep_tristate wants 3 arguments (fwd) Adrian Bunk
2003-12-12 22:34 ` Jeff Garzik [this message]
2003-12-12 22:53 ` Adrian Bunk
2003-12-19 7:02 ` Jeff Garzik
2003-12-21 2:35 ` Adrian Bunk
2003-12-21 4:17 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FDA426B.1060508@pobox.com \
--to=jgarzik@pobox.com \
--cc=bunk@fs.tum.de \
--cc=cgoos@syskonnect.de \
--cc=jochen@scram.de \
--cc=jschlst@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=linux-tr@linuxtr.net \
--cc=marcelo.tosatti@cyclades.com \
--cc=mid@auk.cx \
--cc=phillim@amtrak.com \
--cc=riel@surriel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox