From: Manfred Spraul <manfred@colorfullife.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: lse-tech@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [Lse-tech] [RFC,PATCH] use rcu for fasync_lock
Date: Sat, 20 Dec 2003 22:35:00 +0100 [thread overview]
Message-ID: <3FE4C084.9030807@colorfullife.com> (raw)
In-Reply-To: <3FE4BAE3.5000609@osdl.org>
Stephen Hemminger wrote:
>>
>> +struct fasync_rcu_struct {
>> + struct fasync_struct data;
>> + struct rcu_head rcu;
>> +};
>>
>>
> Why do needless wrapping of existing structure? Just add and rcu
> element to it!
>
There are two independant users of fasync_struct
- networking does it's own locking and allocation and uses __kill_fasync
directly.
- everyone else uses fasync_helper and calls kill_fasync, with the
locking logic in fcntl.c.
I didn't convert the network code, thus I couldn't add the rcu member
into fasync_struct.
--
Manfred
next prev parent reply other threads:[~2003-12-20 21:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-20 18:20 [RFC,PATCH] use rcu for fasync_lock Manfred Spraul
2003-12-20 21:10 ` [Lse-tech] " Stephen Hemminger
2003-12-20 21:35 ` Manfred Spraul [this message]
2003-12-21 11:36 ` Jamie Lokier
2003-12-21 12:40 ` Manfred Spraul
2003-12-21 14:14 ` Jamie Lokier
2003-12-21 14:59 ` Manfred Spraul
2003-12-21 15:08 ` Jamie Lokier
2004-01-02 21:15 ` Bill Davidsen
2004-01-02 22:41 ` Jamie Lokier
2004-01-03 1:09 ` Mike Fedyk
2004-01-03 21:28 ` Jamie Lokier
2004-01-04 19:01 ` Ingo Oeser
2004-01-04 19:20 ` Davide Libenzi
2004-01-05 21:17 ` Ingo Oeser
2004-01-05 22:24 ` Davide Libenzi
2003-12-21 15:14 ` Davide Libenzi
2003-12-21 15:17 ` Davide Libenzi
2003-12-21 15:28 ` Jamie Lokier
2003-12-21 18:38 ` OGAWA Hirofumi
2003-12-21 19:14 ` Manfred Spraul
2003-12-21 20:51 ` Linus Torvalds
2003-12-21 21:08 ` Manfred Spraul
2003-12-21 21:19 ` Linus Torvalds
2003-12-21 21:54 ` Manfred Spraul
2003-12-21 22:05 ` Linus Torvalds
2003-12-25 1:21 ` Manfred Spraul
2003-12-25 15:11 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FE4C084.9030807@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lse-tech@lists.sourceforge.net \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox